Explicitly pass emcc flags to cli

Author: beicause

.github/workflows/ci.yml

@@ -86,12 +86,11 @@ jobs:
         run: cargo build --verbose
 
       - name: Build basisu vendor wasm
-        run: cargo r -p bevy_basisu_loader_sys --bin build-wasm-cli --features build-wasm-cli -- --emcc-flags="-Os -flto=full" --wasm-opt-flags="-Os"
-
+        run: cargo r -p bevy_basisu_loader_sys --bin build-wasm-cli --features build-wasm-cli -- --emcc-flags="-Os -msimd128 -flto=full -sEVAL_CTORS" --wasm-opt-flags="-Os --enable-simd --enable-bulk-memory-opt --enable-nontrapping-float-to-int"
       - name: Upload artifact
         uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
         with:
           path: crates/basisu_sys/wasm/
 
       - name: Build wasm
-        run: cargo build --target wasm32-unknown-unknown
+        run: RUSTFLAGS="-Ctarget-feature=+simd128" cargo build --target wasm32-unknown-unknown

.github/workflows/release.yml

@@ -49,8 +49,7 @@ jobs:
           targets: wasm32-unknown-unknown
 
       - name: Build basisu vendor wasm
-        run: cargo r -p bevy_basisu_loader_sys --bin build-wasm-cli --features build-wasm-cli -- --emcc-flags="-sEVAL_CTORS -Os -flto=full" --wasm-opt-flags="-Os"
-
+        run: cargo r -p bevy_basisu_loader_sys --bin build-wasm-cli --features build-wasm-cli -- --emcc-flags="-Os -msimd128 -flto=full -sEVAL_CTORS" --wasm-opt-flags="-Os --enable-simd --enable-bulk-memory-opt --enable-nontrapping-float-to-int"
       - name: Upload artifact
         uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
         with:

.github/workflows/static.yml

@@ -57,15 +57,14 @@ jobs:
         run: cargo binstall --force wasm-bindgen-cli
 
       - name: Build basisu vendor wasm
-        run: cargo r -p bevy_basisu_loader_sys --bin build-wasm-cli --features build-wasm-cli -- --emcc-flags="-sEVAL_CTORS -Os -flto=full" --wasm-opt-flags="-Os"
-
+        run: cargo r -p bevy_basisu_loader_sys --bin build-wasm-cli --features build-wasm-cli -- --emcc-flags="-Os -msimd128 -flto=full -sEVAL_CTORS" --wasm-opt-flags="-Os --enable-simd --enable-bulk-memory-opt --enable-nontrapping-float-to-int"
       - name: Upload artifact
         uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
         with:
           path: crates/basisu_sys/wasm/
 
       - name: Build
-        run: cargo b -p test_scene --target wasm32-unknown-unknown --profile web_release
+        run: RUSTFLAGS="-Ctarget-feature=+simd128" cargo b -p test_scene --target wasm32-unknown-unknown --profile web_release
 
       - name: Wasm bindgen
         run: wasm-bindgen --out-name wasm_example --out-dir web/target/ --target web target/wasm32-unknown-unknown/web_release/test_scene.wasm

README.md

@@ -59,7 +59,7 @@ TLDR: Just build your bevy application to `wasm32-unknown-unknown` normally.
 
 The prebuilt wasm in `crates/basisu_sys/wasm` is automatically embedded in binary when building. It was prebuilt through CI with:
 ```sh
-cargo r -p bevy_basisu_loader_sys --bin build-wasm-cli --features build-wasm-cli -- --emcc-flags="-sEVAL_CTORS -Os -flto=full" --wasm-opt-flags="-Os"
+cargo r -p bevy_basisu_loader_sys --bin build-wasm-cli --features build-wasm-cli -- --emcc-flags="-Os -msimd128 -flto=full -sEVAL_CTORS" --wasm-opt-flags="-Os --enable-simd --enable-bulk-memory-opt --enable-nontrapping-float-to-int"
 ```
 
 ## Bevy version compatibility

crates/basisu_sys/build.rs

@@ -98,7 +98,6 @@ fn compile_basisu_static() {
 
 fn gen_wasm_build_cmd() {
     let wasm_args = [
-        "-msimd128",
         "-sSTRICT",
         "-sEXPORT_ES6",
         "-sINCOMING_MODULE_JS_API=wasmBinary",

crates/basisu_sys/src/bin/build_wasm_cli.rs

@@ -44,14 +44,7 @@ pub fn build_wasm_cmd() {
 
     if let Some(flags) = user_args.wasm_opt_flags {
         let mut wasm_opt_cmd = std::process::Command::new("wasm-opt");
-        wasm_opt_cmd.args([
-            "--enable-simd",
-            "--enable-bulk-memory-opt",
-            "--enable-nontrapping-float-to-int",
-            "wasm/basisu_vendor.wasm",
-            "-o",
-            "wasm/basisu_vendor.wasm",
-        ]);
+        wasm_opt_cmd.args(["wasm/basisu_vendor.wasm", "-o", "wasm/basisu_vendor.wasm"]);
 
         wasm_opt_cmd.args(flags.split(" ").filter(|s| !s.is_empty()));