extension: use showSaveDialog to replace saveDir config

allows users to select a path to save the dot or svg file

Author: beicause

README.md

@@ -16,7 +16,7 @@ vscode extension for generate call graph in [graphviz dot language](https://www.
 5. Add `.callgraphignore` file in your project root directory to ignore some files or folders in workspace (the syntax is the same as `.gitignore`)
 
 ## Configuration
-You can configure `ignoreFile`(.callgraphignore by default), `maxDepth` and `saveDir` for svg or dot in settings. See the descriptions in setting.
+You can configure `ignoreFile`(.callgraphignore by default), `maxDepth`. See the descriptions in setting.
 
 ## How it works
 It depends `vscode.provideOutgoingCalls` and `vscode.provideIncomingCalls` built-in commands( the same with `Show Call Hierarchy` command, not available for some language server ).

package.json

@@ -41,11 +41,6 @@
         "configuration": {
             "title": "CallGraph",
             "properties": {
-                "call-graph.saveDir": {
-                    "type": "string",
-                    "default": "${workspace}",
-                    "description": "the dir where svg and dot file will be saved"
-                },
                 "call-graph.ignoreFile": {
                     "type": "string",
                     "default": "${workspace}/.callgraphignore",

src/extension.ts

@@ -113,34 +113,18 @@ export function activate(context: vscode.ExtensionContext) {
         const savedName =
             type === 'Incoming' ? 'call_graph_incoming' : 'call_graph_outgoing'
         const dotFile = type === 'Incoming' ? dotFileIncoming : dotFileOutgoing
-        const existed = (p: string) =>
-            vscode.window.showErrorMessage(`Already exists, please delete it manually.\n${p} `)
 
         if (msg.command === 'download') {
-            const dir = vscode.workspace
-                .getConfiguration()
-                .get<string>('call-graph.saveDir')
-                ?.replace('${workspace}', workspace.fsPath)
-            let f = dir ? vscode.Uri.file(dir) : workspace
-            if (!fs.existsSync(f.fsPath))
-                fs.mkdirSync(f.fsPath, { recursive: true })
-
-            switch (msg.type) {
-                case 'dot':
-                    f = vscode.Uri.joinPath(f, `${savedName}.dot`)
-                    if (!fs.existsSync(f.fsPath)) {
-                        fs.copyFileSync(dotFile.fsPath, f.fsPath)
-                        vscode.window.showInformationMessage(f.fsPath)
-                    } else existed(f.fsPath)
-                    break
-                case 'svg':
-                    f = vscode.Uri.joinPath(f, `${savedName}.svg`)
-                    if (!fs.existsSync(f.fsPath)) {
-                        fs.writeFileSync(f.fsPath, msg.data)
-                        vscode.window.showInformationMessage(f.fsPath)
-                    } else existed(f.fsPath)
-                    break
+            const saveFunc = async (fileType: "dot" | "svg") => {
+                const f = await vscode.window.showSaveDialog({
+                    filters: fileType === "svg" ? { "Image": ["svg"] } : { "Graphviz": ["dot", "gv"] },
+                    defaultUri: vscode.Uri.joinPath(workspace, `${savedName}.${fileType}`)
+                })
+                if (!f) return
+                fs.copyFileSync(dotFile.fsPath, f.fsPath)
+                vscode.window.showInformationMessage("Call Graph file saved: " + f.fsPath)
             }
+            saveFunc(msg.type)
         }
     }
     const incomingDisposable = vscode.commands.registerCommand(