Merge pull request #216 from vickgoodman/beman-tidy-additional-tests-readme-implements

[beman-tidy] Updated regex and examples for readme.implements

Author: vickgoodman

beman_tidy/lib/checks/beman_standard/readme.py

@@ -113,15 +113,16 @@ def __init__(self, repo_info, beman_standard_check_config):
     def check(self):
         lines = self.read_lines_strip()
 
-        # Match the pattern to start with "**Implements**:", then have a paper reference with a wg21.link URL.
+        # Matches lines starting with "**Implements**:" that reference a WG21 paper
+        # and include a corresponding https://wg21.link/Pxxxx[Rx] URL
+
         # Examples of valid lines:
         # **Implements**: [Standard Library Concepts (P0898)](https://wg21.link/P0898).
-        # **Implements**: `std::ranges::any_view` proposed in [any_view (P3411R4)](https://wg21.link/p3411r4).
-        # **Implements**: [Give *std::optional* Range Support (P3168R2)](https://wg21.link/p3168r2) and [`std::optional<T&>` (P2988R5)](https://wg21.link/P2988R5)
+        # **Implements**: `std::ranges::any_view` proposed in [any_view (p3411r4)](https://wg21.link/p3411r4).
+        # **Implements**: [Give *std::optional* Range Support (P3168R2)](https://wg21.link/p3168r2) and [`std::optional<T&>` (p2988r5)](https://wg21.link/P2988R5)
         # **Implements**: [.... (P0000)](https://wg21.link/p0000), [.... (P1111R1)](https://wg21.link/p1111r1), and [.... (P2222)](https://wg21.link/p2222),
 
-        regex = r"^\*\*Implements\*\*:\s+.*\bP\d{4}R?\d*\b.*wg21\.link/\S+"
-
+        regex = r"^\*\*Implements\*\*:\s+.*\b[pP]\d{4}(?:[rR]\d+)?\b.*wg21\.link/[pP]\d{4}(?:[rR]\d+)?\b"
         # Count the number of lines that match the regex
         implement_lines = 0
         for line in lines:

tests/lib/checks/beman_standard/readme/data/valid/README-v2.md

@@ -8,7 +8,7 @@
 <!-- markdownlint-disable-next-line line-length -->
 `beman.exemplar` is a minimal C++ library conforming to [The Beman Standard](https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md). This can be used as a template for those intending to write Beman libraries. It may also find use as a minimal and modern  C++ project structure.
 
-**Implements**: `std::identity` proposed in [Standard Library Concepts (P0898R3)](https://wg21.link/P0898R3).
+**Implements**: `std::ranges::any_view` proposed in [any_view (p3411r4)](https://wg21.link/p3411r4).
 
 **Status**: [Production ready. API may undergo changes.](https://github.com/bemanproject/beman/blob/main/docs/beman_library_maturity_model.md#production-ready-api-may-undergo-changes)
 

tests/lib/checks/beman_standard/readme/data/valid/README-v3.md

@@ -8,7 +8,7 @@
 <!-- markdownlint-disable-next-line line-length -->
 `beman.exemplar` is a minimal C++ library conforming to [The Beman Standard](https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md). This can be used as a template for those intending to write Beman libraries. It may also find use as a minimal and modern  C++ project structure.
 
-**Implements**: `std::identity` proposed in [Standard Library Concepts (P0898R3)](https://wg21.link/P0898R3).
+**Implements**: [Give *std::optional* Range Support (p3168r2)](https://wg21.link/p3168r2) and [`std::optional<T&>` (P2988R5)](https://wg21.link/P2988R5)
 
 <!-- markdownlint-disable-next-line line-length -->
 **Status**: [Production ready. Stable API.](https://github.com/bemanproject/beman/blob/main/docs/beman_library_maturity_model.md#production-ready-stable-api)

tests/lib/checks/beman_standard/readme/data/valid/README-v4.md

@@ -8,7 +8,7 @@
 <!-- markdownlint-disable-next-line line-length -->
 `beman.exemplar` is a minimal C++ library conforming to [The Beman Standard](https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md). This can be used as a template for those intending to write Beman libraries. It may also find use as a minimal and modern  C++ project structure.
 
-**Implements**: `std::identity` proposed in [Standard Library Concepts (P0898R3)](https://wg21.link/P0898R3).
+**Implements**: `std::identity` proposed in [Standard Library Concepts (p0898r3)](https://wg21.link/P0898R3).
 
 **Status**: [Retired. No longer maintained or actively developed.](https://github.com/bemanproject/beman/blob/main/docs/beman_library_maturity_model.md#retired-no-longer-maintained-or-actively-developed)