Skip to content

Commit 29c6f37

Browse files
dhollmanclaude
andcommitted
Remove config.hpp and feature detection as requested
This commit addresses review feedback from PR 133: - Removed NOTICE file as requested - Removed all config.hpp.in related code - Removed feature detection code - Left only the essential changes for Beman compliance: - Project name change to beman.execution - Option name changes to follow BEMAN_execution_* format - Removal of target_compile_features with PUBLIC visibility 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent e0e5dd0 commit 29c6f37

File tree

4 files changed

+2
-85
lines changed

4 files changed

+2
-85
lines changed

CMakeLists.txt

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -7,40 +7,6 @@ cmake_minimum_required(VERSION 3.25...3.31)
77

88
project(beman.execution VERSION 0.0.1 LANGUAGES CXX)
99

10-
# Setup C++ feature tests
11-
include(CheckCXXSourceCompiles)
12-
13-
# Check for __cpp_explicit_this_parameter
14-
check_cxx_source_compiles("
15-
struct S {
16-
void f(this S& self) {}
17-
};
18-
int main() { S s; s.f(); }
19-
" BEMAN_EXECUTION_HAS_EXPLICIT_THIS_PARAMETER)
20-
21-
# Check for __cpp_lib_unreachable
22-
check_cxx_source_compiles("
23-
#include <utility>
24-
int main() { std::unreachable(); }
25-
" BEMAN_EXECUTION_HAS_LIB_UNREACHABLE)
26-
27-
# Check for __cpp_lib_forward_like
28-
check_cxx_source_compiles("
29-
#include <utility>
30-
int main() {
31-
int x = 42;
32-
auto&& r = std::forward_like<int&>(x);
33-
return 0;
34-
}
35-
" BEMAN_EXECUTION_HAS_LIB_FORWARD_LIKE)
36-
37-
# Configure the config.hpp file
38-
configure_file(
39-
"${CMAKE_CURRENT_SOURCE_DIR}/include/beman/execution/detail/config/config.hpp.in"
40-
"${CMAKE_CURRENT_BINARY_DIR}/include/beman/execution/detail/config/config.hpp"
41-
@ONLY
42-
)
43-
4410
if(${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_BINARY_DIR})
4511
message(FATAL_ERROR "In-source builds are not allowed!")
4612
endif()
@@ -158,4 +124,4 @@ install(
158124
)
159125

160126
set(CPACK_GENERATOR TGZ)
161-
include(CPack)
127+
include(CPack)

NOTICE

Lines changed: 0 additions & 7 deletions
This file was deleted.

include/beman/execution/detail/config/config.hpp.in

Lines changed: 0 additions & 16 deletions
This file was deleted.

src/beman/execution/CMakeLists.txt

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,6 @@ if(NOT BEMAN_execution_ENABLE_INSTALL OR CMAKE_SKIP_INSTALL_RULES)
1111
target_link_libraries(${TARGET_NAME} PUBLIC $<BUILD_INTERFACE:${TARGET_NAME}_project_warnings>)
1212
endif()
1313

14-
# Add the binary directory to include paths so config.hpp can be found
15-
target_include_directories(${TARGET_NAME}
16-
PUBLIC
17-
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
18-
$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/include>
19-
$<INSTALL_INTERFACE:include>
20-
)
21-
2214
include(CMakePrintHelpers)
2315
cmake_print_variables(TARGET_ALIAS TARGET_NAME TARGET_PREFIX PROJECT_SOURCE_DIR)
2416

@@ -201,19 +193,6 @@ source_group("Header Files\\detail" FILES ${DETAIL_HEADER_FILES})
201193

202194
set_target_properties(${TARGET_NAME} PROPERTIES VERIFY_INTERFACE_HEADER_SETS ON)
203195

204-
# Check for C++26 support at configuration time instead of using target_compile_features
205-
include(CheckCXXCompilerFlag)
206-
check_cxx_compiler_flag("-std=c++26" COMPILER_SUPPORTS_CXX26)
207-
check_cxx_compiler_flag("-std=c++23" COMPILER_SUPPORTS_CXX23)
208-
209-
if(COMPILER_SUPPORTS_CXX26)
210-
message(STATUS "Using C++26 for ${TARGET_NAME}")
211-
elseif(COMPILER_SUPPORTS_CXX23)
212-
message(STATUS "Using C++23 for ${TARGET_NAME}")
213-
else()
214-
message(FATAL_ERROR "The compiler ${CMAKE_CXX_COMPILER} does not support C++23 or later. Please use a different compiler.")
215-
endif()
216-
217196
if(NOT BEMAN_execution_ENABLE_INSTALL OR CMAKE_SKIP_INSTALL_RULES)
218197
return()
219198
endif()
@@ -226,16 +205,11 @@ install(
226205
FILE_SET ${TARGET_NAME}_detail_headers
227206
)
228207

229-
# Install the generated config.hpp file
230-
install(
231-
FILES ${PROJECT_BINARY_DIR}/include/beman/execution/detail/config/config.hpp
232-
DESTINATION include/beman/execution/detail/config
233-
)
234208
# cmake-format: on
235209

236210
install(
237211
EXPORT ${TARGETS_EXPORT_NAME}1
238212
FILE ${TARGETS_EXPORT_NAME}.cmake
239213
DESTINATION "${INSTALL_CONFIGDIR}"
240214
NAMESPACE ${TARGET_NAMESPACE}::
241-
)
215+
)

0 commit comments

Comments
 (0)