Skip to content

Commit 35b7067

Browse files
maikeldietmarkuehl
andcommitted
Change exported install name to beman::execution26 (#109)
* Change exported install name to beman::execution26 * adjust the header update script and add missing headers --------- Co-authored-by: Dietmar Kühl <[email protected]>
1 parent fc84954 commit 35b7067

File tree

5 files changed

+21
-21
lines changed

5 files changed

+21
-21
lines changed

CMakeLists.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ if(${CMAKE_SOURCE_DIR} STREQUAL ${CMAKE_BINARY_DIR})
1212
endif()
1313

1414
set(TARGET_NAME execution26)
15-
set(TARGET_NAMESPACE beman) # FIXME: not used in install(EXPORT ...) CK?
15+
set(TARGET_NAMESPACE beman)
1616
set(TARGET_PREFIX ${TARGET_NAMESPACE}.${TARGET_NAME})
1717
set(TARGET_LIBRARY ${PROJECT_NAME})
18-
set(TARGET_ALIAS ${TARGET_LIBRARY}::${TARGET_LIBRARY})
18+
set(TARGET_ALIAS ${TARGET_NAMESPACE}::${TARGET_NAME})
1919
set(TARGET_PACKAGE_NAME ${PROJECT_NAME}-config)
2020
set(TARGETS_EXPORT_NAME ${PROJECT_NAME}-targets)
2121

@@ -40,7 +40,7 @@ if(CMAKE_BUILD_TYPE STREQUAL Debug)
4040
# uncomment to enable the options. Some of them accept one or more inputs:
4141
project_options(
4242
PREFIX
43-
${PROJECT_NAME}
43+
${TARGET_NAME}
4444
ENABLE_CACHE
4545
ENABLE_CLANG_TIDY
4646
# NO! ENABLE_VS_ANALYSIS

bin/update-cmake-headers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def get_headers(dir):
2929
}
3030

3131
file_set_re = re.compile(" *FILE_SET.*")
32-
section_re = re.compile(" *\${TARGET_LIBRARY}_(?P<section>.*)_headers$")
32+
section_re = re.compile(" *\${TARGET_NAME}_(?P<section>.*)_headers$")
3333
header_re = re.compile(" *\${PROJECT_SOURCE_DIR}/include/beman/.*/.*\.hpp")
3434

3535
if len(sys.argv) != 2:

examples/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,5 +21,5 @@ foreach(EXAMPLE ${EXAMPLES})
2121
set(EXAMPLE_TARGET ${TARGET_PREFIX}.examples.${EXAMPLE})
2222
add_executable(${EXAMPLE_TARGET})
2323
target_sources(${EXAMPLE_TARGET} PRIVATE ${EXAMPLE}.cpp)
24-
target_link_libraries(${EXAMPLE_TARGET} PRIVATE ${TARGET_LIBRARY})
24+
target_link_libraries(${EXAMPLE_TARGET} PRIVATE ${TARGET_NAMESPACE}::${TARGET_NAME})
2525
endforeach()

src/beman/execution26/CMakeLists.txt

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@
33
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
44
# cmake-format: on
55

6-
add_library(${TARGET_LIBRARY} STATIC)
7-
add_library(${TARGET_ALIAS} ALIAS ${TARGET_LIBRARY})
6+
add_library(${TARGET_NAME} STATIC)
7+
add_library(${TARGET_ALIAS} ALIAS ${TARGET_NAME})
88

99
if(CMAKE_BUILD_TYPE STREQUAL Debug)
10-
target_link_libraries(${TARGET_LIBRARY} PUBLIC $<BUILD_INTERFACE:${TARGET_LIBRARY}_project_options>)
11-
target_link_libraries(${TARGET_LIBRARY} PUBLIC $<BUILD_INTERFACE:${TARGET_LIBRARY}_project_warnings>)
10+
target_link_libraries(${TARGET_NAME} PUBLIC $<BUILD_INTERFACE:${TARGET_NAME}_project_options>)
11+
target_link_libraries(${TARGET_NAME} PUBLIC $<BUILD_INTERFACE:${TARGET_NAME}_project_warnings>)
1212
endif()
1313

1414
include(CMakePrintHelpers)
15-
cmake_print_variables(TARGET_ALIAS TARGET_LIBRARY TARGET_PREFIX PROJECT_SOURCE_DIR)
15+
cmake_print_variables(TARGET_ALIAS TARGET_NAME TARGET_PREFIX PROJECT_SOURCE_DIR)
1616

1717
target_sources(
18-
${TARGET_LIBRARY}
18+
${TARGET_NAME}
1919
PRIVATE execution.cpp
2020
PUBLIC FILE_SET
21-
${TARGET_LIBRARY}_public_headers
21+
${TARGET_NAME}_public_headers
2222
TYPE
2323
HEADERS
2424
BASE_DIRS
@@ -29,7 +29,7 @@ target_sources(
2929
${PROJECT_SOURCE_DIR}/include/beman/execution26/functional.hpp
3030
${PROJECT_SOURCE_DIR}/include/beman/execution26/stop_token.hpp
3131
PUBLIC FILE_SET
32-
${TARGET_LIBRARY}_detail_headers
32+
${TARGET_NAME}_detail_headers
3333
TYPE
3434
HEADERS
3535
BASE_DIRS
@@ -198,28 +198,28 @@ target_sources(
198198
)
199199

200200
# cmake-format: off
201-
get_property(DETAIL_HEADER_FILES TARGET ${TARGET_LIBRARY} PROPERTY HEADER_SET_${TARGET_LIBRARY}_detail_headers)
201+
get_property(DETAIL_HEADER_FILES TARGET ${TARGET_NAME} PROPERTY HEADER_SET_${TARGET_NAME}_detail_headers)
202202
source_group("Header Files\\detail" FILES ${DETAIL_HEADER_FILES})
203203

204-
set_target_properties(${TARGET_LIBRARY} PROPERTIES VERIFY_INTERFACE_HEADER_SETS ON)
204+
set_target_properties(${TARGET_NAME} PROPERTIES VERIFY_INTERFACE_HEADER_SETS ON)
205205

206-
target_compile_features(${TARGET_LIBRARY} PUBLIC
206+
target_compile_features(${TARGET_NAME} PUBLIC
207207
"$<$<COMPILE_FEATURES:cxx_std_26>:cxx_std_26>"
208208
"$<$<NOT:$<COMPILE_FEATURES:cxx_std_26>>:cxx_std_23>"
209209
)
210210

211211
install(
212-
TARGETS ${TARGET_LIBRARY}
212+
TARGETS ${TARGET_NAME}
213213
EXPORT ${TARGETS_EXPORT_NAME}1
214214
ARCHIVE DESTINATION lib/$<CONFIG>
215-
FILE_SET ${TARGET_LIBRARY}_public_headers
216-
FILE_SET ${TARGET_LIBRARY}_detail_headers
215+
FILE_SET ${TARGET_NAME}_public_headers
216+
FILE_SET ${TARGET_NAME}_detail_headers
217217
)
218218
# cmake-format: on
219219

220220
install(
221221
EXPORT ${TARGETS_EXPORT_NAME}1
222222
FILE ${TARGETS_EXPORT_NAME}.cmake
223223
DESTINATION "${INSTALL_CONFIGDIR}"
224-
NAMESPACE ${TARGET_LIBRARY}::
224+
NAMESPACE ${TARGET_NAMESPACE}::
225225
)

tests/beman/execution26/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ remove_definitions(-DNDEBUG) # NOTE: we want ASSERT statements in Release too! C
131131
foreach(test ${execution_tests})
132132
set(TEST_EXE ${TARGET_PREFIX}.${test})
133133
add_executable(${TEST_EXE} ${test}.cpp)
134-
target_link_libraries(${TEST_EXE} PRIVATE beman_execution26::beman_execution26)
134+
target_link_libraries(${TEST_EXE} PRIVATE beman::execution26)
135135
add_test(NAME ${TEST_EXE} COMMAND $<TARGET_FILE:${TEST_EXE}>)
136136
endforeach()
137137

0 commit comments

Comments
 (0)