more clang-tidy fixes

Author: dietmarkuehl

include/beman/execution26/detail/basic_sender.hpp

@@ -39,10 +39,10 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
             data.children);
     }
 
-  private:
     template <typename Receiver>
         requires(not::beman::execution26::receiver<Receiver>)
     auto connect(Receiver receiver) = BEMAN_EXECUTION26_DELETE("the passed receiver doesn't model receiver");
+  private:
 #if __cpp_explicit_this_parameter < 202110L
     template <::beman::execution26::receiver Receiver>
     auto connect(Receiver receiver) & noexcept(true /*-dk:TODO*/)

include/beman/execution26/detail/emplace_from.hpp

@@ -17,7 +17,7 @@ struct emplace_from {
     using type = ::beman::execution26::detail::call_result_t<Fun>;
     Fun fun;
 
-    constexpr operator type() && noexcept(::beman::execution26::detail::nothrow_callable<Fun>) {
+    explicit constexpr operator type() && noexcept(::beman::execution26::detail::nothrow_callable<Fun>) {
         return ::std::move(fun)();
     }
 };

include/beman/execution26/detail/forward_like.hpp

@@ -19,14 +19,14 @@ template <typename T>
 struct forward_like_helper {
     template <typename U>
     static auto forward(U&& u) -> ::std::remove_reference_t<U>&& {
-        return ::std::move(u);
+        return ::std::move(u); // NOLINT(bugprone-move-forwarding-reference)
     }
 };
 template <typename T>
 struct forward_like_helper<T&&> {
     template <typename U>
     static auto forward(U&& u) -> ::std::remove_cvref_t<U>&& {
-        return ::std::move(u);
+        return ::std::move(u); // NOLINT(bugprone-move-forwarding-reference)
     }
 };
 template <typename T>
@@ -40,7 +40,7 @@ template <typename T>
 struct forward_like_helper<const T&&> {
     template <typename U>
     static auto forward(U&& u) -> const ::std::remove_cvref_t<U>&& {
-        return ::std::move(u);
+        return ::std::move(u); // NOLINT(bugprone-move-forwarding-reference)
     }
 };
 template <typename T>

include/beman/execution26/detail/fwd_env.hpp

@@ -20,7 +20,7 @@ class fwd_env {
     Env env;
 
   public:
-    fwd_env(Env&& env) : env(::std::forward<Env>(env)) {}
+    explicit fwd_env(Env&& env) : env(::std::forward<Env>(env)) {}
 
     template <typename Query, typename... Args>
         requires(not::beman::execution26::forwarding_query(::std::remove_cvref_t<Query>()))

include/beman/execution26/detail/inplace_stop_source.hpp

@@ -40,7 +40,7 @@ class beman::execution26::inplace_stop_token {
     friend class ::beman::execution26::inplace_stop_source;
     template <typename CallbackFun>
     friend class ::beman::execution26::inplace_stop_callback;
-    inplace_stop_token(::beman::execution26::inplace_stop_source* source) : source(source) {}
+    explicit inplace_stop_token(::beman::execution26::inplace_stop_source* source) : source(source) {}
 
     ::beman::execution26::inplace_stop_source* source{};
 };

include/beman/execution26/detail/notify.hpp

@@ -5,20 +5,17 @@
 #define INCLUDED_BEMAN_EXECUTION26_DETAIL_NOTIFY
 
 #include <beman/execution26/detail/make_sender.hpp>
+#include <beman/execution26/detail/immovable.hpp>
 #include <mutex>
 #include <utility>
-#include <iostream> //-dk:TODO remove
-#include <cassert>  //-dk:TODO remove
 
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26::detail {
 struct notify_t;
-class notifier {
+class notifier
+: ::beman::execution26::detail::immovable {
   public:
-    notifier()           = default;
-    notifier(notifier&&) = delete;
-
     auto complete() -> void {
         ::std::unique_lock kerberos(this->lock);
         this->completed = true;

include/beman/execution26/detail/sched_attrs.hpp

@@ -23,10 +23,8 @@ class sched_attrs {
     Scheduler sched;
 
   public:
-    sched_attrs(const sched_attrs&) = default;
-    sched_attrs(sched_attrs&&)      = default;
     template <typename S>
-    explicit sched_attrs(S&& sched) : sched(::std::forward<S>(sched)) {}
+    explicit sched_attrs(S sched) : sched(::std::move(sched)) {}
 
     template <typename Tag>
     auto query(const ::beman::execution26::get_completion_scheduler_t<Tag>&) const noexcept {

include/beman/execution26/detail/sched_env.hpp

@@ -19,10 +19,8 @@ class sched_env {
     Scheduler sched;
 
   public:
-    sched_env(const sched_env&) = default;
-    sched_env(sched_env&&)      = default;
     template <typename S>
-    explicit sched_env(S&& sch) : sched(::std::forward<S>(sch)) {}
+    explicit sched_env(S sch) : sched(::std::move(sch)) {}
 
     auto query(const ::beman::execution26::get_scheduler_t&) const noexcept { return this->sched; }
     auto query(const ::beman::execution26::get_domain_t& q) const noexcept {

include/beman/execution26/detail/simple_counting_scope.hpp

@@ -6,6 +6,7 @@
 
 #include <beman/execution26/detail/sender.hpp>
 #include <beman/execution26/detail/notify.hpp>
+#include <beman/execution26/detail/immovable.hpp>
 #include <atomic>
 #include <mutex>
 #include <utility>
@@ -19,15 +20,12 @@ class simple_counting_scope;
 
 // ----------------------------------------------------------------------------
 
-class beman::execution26::simple_counting_scope {
+class beman::execution26::simple_counting_scope
+: ::beman::execution26::detail::immovable {
   public:
     class token;
     class assoc;
 
-    simple_counting_scope()                        = default;
-    simple_counting_scope(simple_counting_scope&&) = delete;
-    ~simple_counting_scope()                       = default;
-
     auto get_token() noexcept -> token;
     auto close() noexcept -> void {
         switch (this->state) {
@@ -60,7 +58,7 @@ class beman::execution26::simple_counting_scope {
     }
 
   private:
-    enum class state_t { unused, open, open_and_joining, closed, closed_and_joining, unused_and_closed, joined };
+    enum class state_t: unsigned char { unused, open, open_and_joining, closed, closed_and_joining, unused_and_closed, joined };
     friend class assoc;
     auto try_associate() noexcept -> simple_counting_scope* {
         ::std::lock_guard lock(this->mutex);
@@ -92,6 +90,7 @@ class beman::execution26::simple_counting_scope {
 
 // ----------------------------------------------------------------------------
 
+// NOLINTBEGIN(misc-unconventional-assign-operator)
 class beman::execution26::simple_counting_scope::assoc {
   public:
     assoc() = default;
@@ -102,7 +101,7 @@ class beman::execution26::simple_counting_scope::assoc {
             this->scope->disassociate();
     }
 
-    auto operator=(assoc other) noexcept -> assoc {
+    auto operator=(assoc other) noexcept -> assoc& {
         ::std::swap(this->scope, other.scope);
         return *this;
     }
@@ -115,6 +114,7 @@ class beman::execution26::simple_counting_scope::assoc {
         : scope(scope ? scope->try_associate() : nullptr) {}
     beman::execution26::simple_counting_scope* scope{};
 };
+// NOLINTEND(misc-unconventional-assign-operator)
 
 // ----------------------------------------------------------------------------
 

tests/beman/execution26/exec-get-domain.test.cpp

@@ -51,6 +51,5 @@ TEST(exec_get_domain) {
     test_get_domain<false, bool>(has_get_domain<false, domain>{42});
     test_get_domain<true, domain>(overloaded_get_domain{});
 
-    ASSERT(42 == test_std::get_domain(has_get_domain<true, domain>{42}).value);
     static_assert(42 == test_std::get_domain(has_get_domain<true, domain>{42}).value);
 }