Skip to content

Commit a38953d

Browse files
committed
another attempt at fixing a gcc compilation issue
1 parent ab3a204 commit a38953d

File tree

4 files changed

+11
-13
lines changed

4 files changed

+11
-13
lines changed

include/beman/execution26/detail/basic_sender.hpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
4444
auto connect(Receiver receiver) = BEMAN_EXECUTION26_DELETE("the passed receiver doesn't model receiver");
4545

4646
private:
47-
#if __cpp_explicit_this_parameter < 202110L
47+
#if __cpp_explicit_this_parameter < 302110L //-dk:TODO need to figure out how to use explicit this with forwarding
4848
template <::beman::execution26::receiver Receiver>
4949
auto connect(Receiver receiver) & noexcept(
5050
noexcept(::beman::execution26::detail::basic_operation<basic_sender&, Receiver>{*this, ::std::move(receiver)}))
@@ -66,9 +66,10 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
6666
}
6767
#else
6868
template <::beman::execution26::detail::decays_to<basic_sender> Self, ::beman::execution26::receiver Receiver>
69-
auto connect(this Self&& self, Receiver receiver) noexcept(
70-
noexcept(::beman::execution26::detail::basic_operation<basic_sender, Receiver>{::std::forward<Self>(self),
71-
::std::move(receiver)}))
69+
auto
70+
connect(this Self&& self,
71+
Receiver receiver) noexcept(noexcept(::beman::execution26::detail::basic_operation<basic_sender, Receiver>{
72+
::std::forward<Self>(self), ::std::move(receiver)}))
7273
-> ::beman::execution26::detail::basic_operation<Self, Receiver> {
7374
return {::std::forward<Self>(self), ::std::move(receiver)};
7475
}

include/beman/execution26/detail/get_completion_signatures.hpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,8 @@ struct get_completion_signatures_t {
2525
static auto get(Sender&& sender, Env&& env) noexcept {
2626
auto new_sender{[](auto&& sndr, auto&& e) -> decltype(auto) {
2727
auto domain{::beman::execution26::detail::get_domain_late(sndr, e)};
28-
return ::beman::execution26::transform_sender(domain,
29-
::std::forward<Sender>(sndr),
30-
::std::forward<Env>(e));
28+
return ::beman::execution26::transform_sender(
29+
domain, ::std::forward<Sender>(sndr), ::std::forward<Env>(e));
3130
}};
3231

3332
using sender_type = ::std::remove_cvref_t<decltype(new_sender(sender, env))>;

include/beman/execution26/detail/simple_counting_scope.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,7 @@ class beman::execution26::simple_counting_scope::assoc {
118118

119119
private:
120120
friend class beman::execution26::simple_counting_scope::token;
121-
explicit assoc(beman::execution26::simple_counting_scope* scp)
122-
: scope(scp ? scp->try_associate() : nullptr) {}
121+
explicit assoc(beman::execution26::simple_counting_scope* scp) : scope(scp ? scp->try_associate() : nullptr) {}
123122
beman::execution26::simple_counting_scope* scope{};
124123
};
125124
// NOLINTEND(misc-unconventional-assign-operator,hicpp-special-member-functions)

tests/beman/execution26/exec-connect.test.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,7 @@ struct receiver {
6767
int value{};
6868
bool* set_stopped_called{};
6969

70-
explicit receiver(int val, bool* called = {})
71-
: value(val), set_stopped_called(called) {}
70+
explicit receiver(int val, bool* called = {}) : value(val), set_stopped_called(called) {}
7271
receiver(receiver&&) = default;
7372
receiver(const receiver&) = delete;
7473
~receiver() = default;
@@ -295,7 +294,7 @@ auto test_connect_awaitable() -> void {
295294
}
296295

297296
auto test_connect_with_awaiter() -> void {
298-
struct awaiter {
297+
struct local_awaiter {
299298
::std::coroutine_handle<>& handle;
300299
auto await_ready() -> bool { return {}; }
301300
auto await_suspend(std::coroutine_handle<> h) -> void { this->handle = h; }
@@ -311,7 +310,7 @@ auto test_connect_with_awaiter() -> void {
311310

312311
std::coroutine_handle<> handle{};
313312
bool result{};
314-
auto op{test_std::connect(awaiter{handle}, local_receiver{result})};
313+
auto op{test_std::connect(local_awaiter{handle}, local_receiver{result})};
315314
ASSERT(handle == std::coroutine_handle{});
316315
test_std::start(op);
317316
ASSERT(handle != std::coroutine_handle{});

0 commit comments

Comments
 (0)