Merge pull request #72 from beman-project/address-clang-tidy-reports

Address clang tidy reports

Author: dietmarkuehl

.nojekyll

@@ -89,8 +89,12 @@ clang-tidy: build/$(SANITIZER)/compile_commands.json
 codespell:
 	codespell -L statics,snd,copyable,cancelled
 
-format:
+format: cmake-format clang-format
+
+cmake-format:
 	cmake-format -i `git diff --name-only main | egrep '(CMakeLists.txt|\.cmake)'`
+
+clang-format:
 	git clang-format main
 
 todo:

Makefile

@@ -19,7 +19,7 @@ template <typename T, typename Context>
  * \headerfile beman/execution26/execution.hpp <beman/execution26/execution.hpp>
  * \internal
  */
-auto allocator_aware_move(T&& obj, Context&& context) -> decltype(auto) {
+auto allocator_aware_move(T&& obj, Context&& context) noexcept -> decltype(auto) {
     if constexpr (requires { ::beman::execution26::get_allocator(::beman::execution26::get_env(context)); }) {
         if constexpr (decltype(::beman::execution26::detail::is_product_type(obj))()) {
             return obj.make_from(::beman::execution26::get_allocator(::beman::execution26::get_env(context)),

include/beman/execution26/detail/allocator_aware_move.hpp

@@ -38,8 +38,11 @@ template <typename Sender, typename Receiver>
     basic_operation(Sender&& sender, Receiver&& receiver) noexcept(true /*-dk:TODO*/)
         : ::beman::execution26::detail::basic_state<Sender, Receiver>(::std::forward<Sender>(sender),
                                                                       ::std::move(receiver)),
+          // NOLINTBEGIN(bugprone-use-after-move,hicpp-invalid-access-moved)
+          //-dk:TODO deal with moving the sender twice
           inner_ops(::beman::execution26::detail::connect_all(
               this, ::std::forward<Sender>(sender), ::beman::execution26::detail::indices_for<Sender>())) {}
+    // NOLINTEND(bugprone-use-after-move,hicpp-invalid-access-moved)
 
   private:
     auto start() & noexcept -> void {

include/beman/execution26/detail/basic_operation.hpp

@@ -15,6 +15,8 @@
 #include <beman/execution26/detail/get_completion_signatures.hpp>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26::detail {
@@ -37,10 +39,11 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
             data.children);
     }
 
-  private:
     template <typename Receiver>
         requires(not::beman::execution26::receiver<Receiver>)
     auto connect(Receiver receiver) = BEMAN_EXECUTION26_DELETE("the passed receiver doesn't model receiver");
+
+  private:
 #if __cpp_explicit_this_parameter < 202110L
     template <::beman::execution26::receiver Receiver>
     auto connect(Receiver receiver) & noexcept(true /*-dk:TODO*/)
@@ -97,4 +100,6 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif

include/beman/execution26/detail/basic_sender.hpp

@@ -17,7 +17,7 @@ struct emplace_from {
     using type = ::beman::execution26::detail::call_result_t<Fun>;
     Fun fun;
 
-    constexpr operator type() && noexcept(::beman::execution26::detail::nothrow_callable<Fun>) {
+    explicit constexpr operator type() && noexcept(::beman::execution26::detail::nothrow_callable<Fun>) {
         return ::std::move(fun)();
     }
 };

include/beman/execution26/detail/emplace_from.hpp

@@ -19,14 +19,14 @@ template <typename T>
 struct forward_like_helper {
     template <typename U>
     static auto forward(U&& u) -> ::std::remove_reference_t<U>&& {
-        return ::std::move(u);
+        return ::std::move(u); // NOLINT(bugprone-move-forwarding-reference)
     }
 };
 template <typename T>
 struct forward_like_helper<T&&> {
     template <typename U>
     static auto forward(U&& u) -> ::std::remove_cvref_t<U>&& {
-        return ::std::move(u);
+        return ::std::move(u); // NOLINT(bugprone-move-forwarding-reference)
     }
 };
 template <typename T>
@@ -40,7 +40,7 @@ template <typename T>
 struct forward_like_helper<const T&&> {
     template <typename U>
     static auto forward(U&& u) -> const ::std::remove_cvref_t<U>&& {
-        return ::std::move(u);
+        return ::std::move(u); // NOLINT(bugprone-move-forwarding-reference)
     }
 };
 template <typename T>

include/beman/execution26/detail/forward_like.hpp

@@ -9,6 +9,8 @@
 #include <type_traits>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26::detail {
@@ -18,7 +20,7 @@ class fwd_env {
     Env env;
 
   public:
-    fwd_env(Env&& env) : env(::std::forward<Env>(env)) {}
+    explicit fwd_env(Env&& env) : env(::std::forward<Env>(env)) {}
 
     template <typename Query, typename... Args>
         requires(not::beman::execution26::forwarding_query(::std::remove_cvref_t<Query>()))
@@ -39,4 +41,6 @@ fwd_env(Env&&) -> fwd_env<Env>;
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif

include/beman/execution26/detail/fwd_env.hpp

@@ -10,6 +10,8 @@
 #include <concepts>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -54,4 +56,6 @@ inline constexpr get_allocator_t get_allocator{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif

include/beman/execution26/detail/get_allocator.hpp

@@ -18,6 +18,8 @@
 #include <type_traits>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -82,4 +84,6 @@ inline constexpr get_completion_scheduler_t<Tag> get_completion_scheduler{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif