fixed an issue detected by MSVC++

Author: dietmarkuehl

tests/beman/execution26/exec-let.test.cpp

@@ -117,7 +117,7 @@ TEST(exec_let) {
     try {
         test_let_value();
         test_let_value_allocator();
-    } catch (const std::exception& e) {
+    } catch (...) {
         // NOLINTBEGIN(cert-dcl03-c,hicpp-static-assert,misc-static-assert)
         ASSERT(nullptr == "let tests are not expected to throw");
         // NOLINTEND(cert-dcl03-c,hicpp-static-assert,misc-static-assert)

tests/beman/execution26/exec-snd-expos.test.cpp

@@ -935,7 +935,8 @@ auto test_connect_all() -> void {
         static_assert(requires { s.connect(receiver{}); });
         static_assert(requires { test_std::connect(s, receiver{}); });
         test_detail::basic_state state{std::move(s), receiver{}};
-        auto product{test_detail::connect_all(&state, std::move(s), std::index_sequence<0, 1, 2, 3>{})};
+        const sender4            s1{};
+        auto product{test_detail::connect_all(&state, std::move(s1), std::index_sequence<0, 1, 2, 3>{})};
         ASSERT(product.size() == 4);
         test::use(product);
     }

tests/beman/execution26/stopsource-cons.test.cpp

@@ -8,25 +8,36 @@
 #include <cstddef>
 #include <cstring>
 
+namespace {
 bool fail{};
 
+}
+
+// NOLINTNEXTLINE(hicpp-no-malloc)
 auto operator new(::std::size_t size) -> void* { return fail ? throw ::std::bad_alloc() : ::std::malloc(size); }
 
-auto operator delete(void* ptr) noexcept -> void { ::std::free(ptr); }
-auto operator delete(void* ptr, ::std::size_t) noexcept -> void { ::std::free(ptr); }
+auto operator delete(void* ptr) noexcept -> void { ::std::free(ptr); }                // NOLINT(hicpp-no-malloc)
+auto operator delete(void* ptr, ::std::size_t) noexcept -> void { ::std::free(ptr); } // NOLINT(hicpp-no-malloc)
 
 TEST(stopsource_cons) {
     // Reference: [stopsource.cons] p1
     ::test_std::stop_source source;
-    ASSERT(source.stop_possible());
-    ASSERT((not source.stop_requested()));
+    try {
+        ASSERT(source.stop_possible());
+        ASSERT((not source.stop_requested()));
+    } catch (...) {
+        ASSERT(nullptr == "can't be reached"); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert)
+    }
 
     // Reference: [stopsource.cons] p3
     fail = true;
     try {
-        ::test_std::stop_source();
-        ASSERT(nullptr == "can't be reached");
+        ::test_std::stop_source source{};
+        test::use(source);
+        ASSERT(nullptr == "can't be reached"); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert)
     } catch (const ::std::bad_alloc&) {
-        ASSERT(nullptr != "bad_alloc was thrown");
+        ASSERT(nullptr != "bad_alloc was thrown"); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert)
+    } catch (...) {
+        ASSERT(nullptr == "can't be reached"); // NOLINT(cert-dcl03-c,hicpp-static-assert,misc-static-assert)
     }
 }