fixed warnings and clang-tidy reports

dietmarkuehl · dietmarkuehl · commit fcb61dfec653 · 2024-11-07T21:16:21.000Z
diff --git a/include/beman/execution26/detail/basic_sender.hpp b/include/beman/execution26/detail/basic_sender.hpp
@@ -15,6 +15,8 @@
 #include <beman/execution26/detail/get_completion_signatures.hpp>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26::detail {
@@ -97,4 +99,6 @@ struct basic_sender : ::beman::execution26::detail::product_type<Tag, Data, Chil
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/fwd_env.hpp b/include/beman/execution26/detail/fwd_env.hpp
@@ -9,6 +9,8 @@
 #include <type_traits>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26::detail {
@@ -39,4 +41,6 @@ fwd_env(Env&&) -> fwd_env<Env>;
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/get_allocator.hpp b/include/beman/execution26/detail/get_allocator.hpp
@@ -10,6 +10,8 @@
 #include <concepts>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -54,4 +56,6 @@ inline constexpr get_allocator_t get_allocator{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/get_completion_scheduler.hpp b/include/beman/execution26/detail/get_completion_scheduler.hpp
@@ -18,6 +18,8 @@
 #include <type_traits>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -82,4 +84,6 @@ inline constexpr get_completion_scheduler_t<Tag> get_completion_scheduler{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/get_domain.hpp b/include/beman/execution26/detail/get_domain.hpp
@@ -8,6 +8,8 @@
 #include <beman/execution26/detail/forwarding_query.hpp>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -40,4 +42,6 @@ inline constexpr get_domain_t get_domain{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/schedule.hpp b/include/beman/execution26/detail/schedule.hpp
@@ -8,6 +8,8 @@
 #include <beman/execution26/detail/common.hpp>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -33,4 +35,6 @@ inline constexpr ::beman::execution26::schedule_t schedule{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/set_error.hpp b/include/beman/execution26/detail/set_error.hpp
@@ -7,6 +7,8 @@
 #include <beman/execution26/detail/common.hpp>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -47,4 +49,6 @@ inline constexpr set_error_t set_error{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/set_stopped.hpp b/include/beman/execution26/detail/set_stopped.hpp
@@ -7,6 +7,8 @@
 #include <beman/execution26/detail/common.hpp>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -45,4 +47,6 @@ inline constexpr set_stopped_t set_stopped{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/set_value.hpp b/include/beman/execution26/detail/set_value.hpp
@@ -7,6 +7,8 @@
 #include <beman/execution26/detail/common.hpp>
 #include <utility>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -47,4 +49,6 @@ inline constexpr set_value_t set_value{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/start.hpp b/include/beman/execution26/detail/start.hpp
@@ -6,6 +6,8 @@
 
 #include <beman/execution26/detail/common.hpp>
 
+#include <beman/execution26/detail/suppress_push.hpp>
+
 // ----------------------------------------------------------------------------
 
 namespace beman::execution26 {
@@ -45,4 +47,6 @@ inline constexpr start_t start{};
 
 // ----------------------------------------------------------------------------
 
+#include <beman/execution26/detail/suppress_pop.hpp>
+
 #endif
diff --git a/include/beman/execution26/detail/suppress_push.hpp b/include/beman/execution26/detail/suppress_push.hpp
@@ -14,4 +14,5 @@
 #define BEMAN_EXECUTION26_DIAGNOSTIC_PUSHED
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wmissing-braces"
+#pragma clang diagnostic ignored "-Wc++26-extensions"
 #endif
diff --git a/tests/beman/execution26/exec-awaitable.test.cpp b/tests/beman/execution26/exec-awaitable.test.cpp
@@ -147,6 +147,7 @@ auto test_with_await_transform() -> void {
     static_assert(noexcept(promise.await_transform(with_as_awaitable<awaiter<bool, void>, true>{})));
     static_assert(not noexcept(promise.await_transform(with_as_awaitable<awaiter<bool, void>, false>{})));
     auto a2{promise.await_transform(with_as_awaitable<awaiter<bool, void>>{})};
+    test::use(a2);
     static_assert(std::same_as<awaiter<bool, void>, decltype(a2)>);
 }
 
diff --git a/tests/beman/execution26/exec-connect.test.cpp b/tests/beman/execution26/exec-connect.test.cpp
@@ -246,6 +246,7 @@ auto test_connect_awaitable() -> void {
         ASSERT(handle != std::coroutine_handle<>());
         ASSERT(iv == 0 && bv == false);
         result = 42;
+        test::use(result);
         handle.resume();
         ASSERT(iv == 42 && bv == true);
     }
@@ -261,6 +262,7 @@ auto test_connect_awaitable() -> void {
         ASSERT(handle != std::coroutine_handle<>());
         ASSERT(iv == 0 && bv == false);
         result = 0;
+        test::use(result);
         handle.resume();
         ASSERT(iv == 0 && bv == true);
     }
diff --git a/tests/beman/execution26/exec-get-env.test.cpp b/tests/beman/execution26/exec-get-env.test.cpp
@@ -44,10 +44,13 @@ TEST(exec_get_env) {
     static_assert(std::same_as<const test_std::get_env_t, decltype(test_std::get_env)>);
 
     auto e0 = test_std::get_env(0);
+    test::use(e0);
     static_assert(std::same_as<test_std::empty_env, decltype(e0)>);
     auto e1 = test_std::get_env(non_const{});
+    test::use(e1);
     static_assert(std::same_as<test_std::empty_env, decltype(e1)>);
     auto e2 = test_std::get_env(normal<test_env>{});
+    test::use(e2);
     static_assert(std::same_as<test_env, decltype(e2)>);
     //-dk:TODO add negative compilation test: auto e3 = test_std::get_env(normal<test_env, false>{});
     //-dk:TODO add negative compilation test: auto e4 = test_std::get_env(with_non_env{});
diff --git a/tests/beman/execution26/exec-read-env.test.cpp b/tests/beman/execution26/exec-read-env.test.cpp
@@ -45,6 +45,7 @@ auto test_read_env() -> void {
     ASSERT(domain{17} == test_std::get_domain(env{17}));
     ASSERT(domain{17} == test_std::get_domain(test_std::get_env(receiver{17})));
     auto sender{test_std::read_env(test_std::get_domain)};
+    test::use(sender);
     static_assert(test_std::sender<decltype(sender)>);
     static_assert(test_std::sender_in<decltype(sender), env>);
     static_assert(
diff --git a/tests/beman/execution26/execution-syn.test.cpp b/tests/beman/execution26/execution-syn.test.cpp
@@ -265,6 +265,7 @@ auto test_conect_result_t() -> void {
     static_assert(requires { connect_sender{}.connect(receiver{}); });
 
     auto op{test_std::connect(connect_sender{}, receiver{})};
+    test::use(op);
     static_assert(std::same_as<decltype(op), test_std::connect_result_t<connect_sender, receiver>>);
 }
 auto test_decays_to() -> void {
@@ -306,8 +307,10 @@ auto test_sender_adaptor_closure() -> void {
     static_assert(not test_std::sender<closure_t>);
 
     auto direct{closure(sender{})};
+    test::use(direct);
     static_assert(std::same_as<adapted_sender<sender>, decltype(direct)>);
     auto via_op{sender{} | closure};
+    test::use(via_op);
     static_assert(std::same_as<adapted_sender<sender>, decltype(via_op)>);
 }
 
@@ -329,8 +332,10 @@ auto test_sender_adaptor() -> void {
     auto closure{arg_closure(17)};
     static_assert(std::same_as<test_detail::sender_adaptor<arg_closure_t, int>, decltype(closure)>);
     auto direct{closure(sender{})};
+    test::use(direct);
     static_assert(std::same_as<adapted_sender<sender>, decltype(direct)>);
     auto via_op{sender{} | closure};
+    test::use(via_op);
     static_assert(std::same_as<adapted_sender<sender>, decltype(via_op)>);
 }
 
