Skip to content

Commit d62d6c4

Browse files
committed
Respect review comments
1 parent 03af50f commit d62d6c4

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ install(
9191

9292
FILE_SET CXX_MODULES
9393
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
94+
CXX_MODULES_BMI
95+
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/beman.scope/bmi-${CMAKE_CXX_COMPILER_ID}_$<CONFIG>
9496
FILE_SET HEADERS
9597
)
9698

examples/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
set(ALL_EXAMPLES scope_example unique_resource unique_resource-file)
44

55
# module tests will only compile with gcc15 or clang20 and above
6-
if(CMAKE_CXX_SCAN_FOR_MODULES)
6+
if(CMAKE_CXX_SCAN_FOR_MODULES AND CMAKE_CXX_MODULE_STD)
77
list(APPEND ALL_EXAMPLES scope-module)
88
endif()
99

examples/scope-module.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,12 @@
1515
// destroy noisy
1616
// scope exit: true success: true fail: false
1717

18-
#ifdef HAS_MODULE_STD
18+
// #ifdef HAS_MODULE_STD
1919
import std;
20-
#else
21-
#include <print>
22-
#endif
20+
// #else
21+
// NOTE: this needs C++23!
22+
// #include <print>
23+
// #endif
2324

2425
import beman.scope;
2526

0 commit comments

Comments
 (0)