Remove importing logging from module as when logging config is applied it happens globally on the logging module

Author: rragundez

src/app/__init__.py

@@ -0,0 +1,5 @@
+# Setup logging before anything else so that all modules have logging configured at import time
+# except for .config.settings as it is imported in logger.py
+from .core.logger import setup_logging
+
+setup_logging()

src/app/api/dependencies.py

@@ -1,3 +1,4 @@
+import logging
 from typing import Annotated, Any
 
 from fastapi import Depends, HTTPException, Request
@@ -6,7 +7,6 @@
 from ..core.config import settings
 from ..core.db.database import async_get_db
 from ..core.exceptions.http_exceptions import ForbiddenException, RateLimitException, UnauthorizedException
-from ..core.logger import logging
 from ..core.security import TokenType, oauth2_scheme, verify_token
 from ..core.utils.rate_limit import rate_limiter
 from ..crud.crud_rate_limit import crud_rate_limits

src/app/core/setup.py

@@ -13,7 +13,6 @@
 from fastapi.openapi.utils import get_openapi
 
 from ..api.dependencies import get_current_superuser
-from ..core.logger import setup_logging
 from ..core.utils.rate_limit import rate_limiter
 from ..middleware.client_cache_middleware import ClientCacheMiddleware
 from ..models import *  # noqa: F403
@@ -189,8 +188,6 @@ def create_application(
     for caching, queue, and rate limiting, client-side caching, and customizing the API documentation
     based on the environment settings.
     """
-    setup_logging()
-
     if isinstance(settings, AppSettings):
         to_update = {
             "title": settings.APP_NAME,

src/app/core/utils/rate_limit.py

@@ -1,19 +1,19 @@
+import logging
 from datetime import UTC, datetime
 from typing import Optional
 
 from redis.asyncio import ConnectionPool, Redis
 from sqlalchemy.ext.asyncio import AsyncSession
 
-from ...core.logger import logging
 from ...schemas.rate_limit import sanitize_path
 
 logger = logging.getLogger(__name__)
 
 
 class RateLimiter:
     _instance: Optional["RateLimiter"] = None
-    pool: Optional[ConnectionPool] = None
-    client: Optional[Redis] = None
+    pool: ConnectionPool | None = None
+    client: Redis | None = None
 
     def __new__(cls) -> "RateLimiter":
         if cls._instance is None:

src/scripts/create_first_superuser.py

@@ -11,7 +11,6 @@
 from ..app.core.security import get_password_hash
 from ..app.models.user import User
 
-logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
 

src/scripts/create_first_tier.py

@@ -7,7 +7,6 @@
 from ..app.core.db.database import AsyncSession, local_session
 from ..app.models.tier import Tier
 
-logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)