Merge pull request #17 from benavlabs/session-type-hint-fix

update type annotation from session to session generator

Author: igorbenav

crudadmin/admin_interface/crud_admin.py

@@ -5,6 +5,7 @@
 from datetime import UTC, datetime, timedelta
 from typing import (
     Any,
+    AsyncGenerator,
     Dict,
     List,
     Optional,
@@ -84,7 +85,7 @@ class CRUDAdmin:
         - Token-based authentication
 
     Args:
-        session: Async SQLAlchemy session for database operations
+        session: Async SQLAlchemy session dependency function that yields sessions
         SECRET_KEY: Secret key for session management and cookie signing. Generate securely using:
             **Python one-liner (recommended)**
             python -c "import secrets; print(secrets.token_urlsafe(32))"
@@ -290,7 +291,7 @@ class OrderUpdate(BaseModel):
 
     def __init__(
         self,
-        session: AsyncSession,
+        session: Callable[[], AsyncGenerator[AsyncSession, None]],
         SECRET_KEY: str,
         mount_path: Optional[str] = "/admin",
         theme: Optional[str] = "dark-theme",

crudadmin/core/db.py

@@ -59,7 +59,7 @@ class DatabaseConfig:
     def __init__(
         self,
         base: Type[DeclarativeBase],
-        session: AsyncSession,
+        session: Callable[[], AsyncGenerator[AsyncSession, None]],
         admin_db_url: Optional[str] = None,
         admin_db_path: Optional[str] = None,
         admin_user: Optional[Type[DeclarativeBase]] = None,
@@ -88,7 +88,7 @@ def __init__(
         ] = None,
     ) -> None:
         self.base: Type[DeclarativeBase] = base
-        self.session: AsyncSession = session
+        self.session: Callable[[], AsyncGenerator[AsyncSession, None]] = session
 
         if admin_db_url is None:
             if admin_db_path is None:
@@ -197,8 +197,8 @@ def get_admin_session(self) -> AsyncSession:
         """Get a session for the admin database."""
         return self.admin_session
 
-    def get_app_session(self) -> AsyncSession:
-        """Get a session for the main application database."""
+    def get_app_session(self) -> Callable[[], AsyncGenerator[AsyncSession, None]]:
+        """Get a session dependency for the main application database."""
         return self.session
 
     def get_primary_key(self, model: Type[DeclarativeBase]) -> Optional[str]: