Skip to content

Commit 9818a20

Browse files
committed
fix linting
1 parent f8218d7 commit 9818a20

30 files changed

+151
-148
lines changed

crudadmin/admin_interface/admin_site.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
1-
from datetime import timedelta, timezone, datetime
2-
from typing import Optional, Any, Callable, Dict, cast, AsyncGenerator
31
import logging
2+
from datetime import datetime, timedelta, timezone
3+
from typing import Any, AsyncGenerator, Callable, Dict, Optional, cast
44

5-
from fastcrud import FastCRUD
6-
from fastapi import Request, APIRouter, Depends, Response, Cookie
5+
from fastapi import APIRouter, Cookie, Depends, Request, Response
76
from fastapi.responses import RedirectResponse
8-
from fastapi.templating import Jinja2Templates
97
from fastapi.security import OAuth2PasswordRequestForm
8+
from fastapi.templating import Jinja2Templates
9+
from fastcrud import FastCRUD
1010
from sqlalchemy.ext.asyncio import AsyncSession
1111

12-
from .auth import AdminAuthentication
13-
from .typing import RouteResponse
1412
from ..admin_user.service import AdminUserService
1513
from ..core.db import DatabaseConfig
14+
from ..event import EventType, log_auth_action
1615
from ..session.manager import SessionManager
17-
from ..event import log_auth_action, EventType
16+
from .auth import AdminAuthentication
17+
from .typing import RouteResponse
1818

1919
logger = logging.getLogger(__name__)
2020

crudadmin/admin_interface/auth.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,22 @@
1-
from typing import Optional
21
import logging
3-
from fastapi import Depends, Cookie, Request
2+
from typing import Optional
3+
4+
from fastapi import Cookie, Depends, Request
45
from fastapi.security import OAuth2PasswordBearer
56
from sqlalchemy.ext.asyncio import AsyncSession
67

7-
from ..core.exceptions import UnauthorizedException, ForbiddenException
8-
from ..admin_user.service import AdminUserService
8+
from ..admin_token.schemas import AdminTokenBlacklistCreate, AdminTokenBlacklistUpdate
99
from ..admin_token.service import TokenService
1010
from ..admin_user.schemas import (
1111
AdminUserCreate,
12+
AdminUserRead,
1213
AdminUserUpdate,
1314
AdminUserUpdateInternal,
14-
AdminUserRead,
1515
)
16-
from ..admin_token.schemas import AdminTokenBlacklistCreate, AdminTokenBlacklistUpdate
17-
from ..session.schemas import AdminSessionCreate, AdminSessionUpdate
16+
from ..admin_user.service import AdminUserService
1817
from ..core.db import DatabaseConfig
18+
from ..core.exceptions import ForbiddenException, UnauthorizedException
19+
from ..session.schemas import AdminSessionCreate, AdminSessionUpdate
1920

2021
logger = logging.getLogger(__name__)
2122

@@ -100,13 +101,13 @@ async def get_current_user_inner(
100101
if isinstance(user, dict):
101102
try:
102103
user = AdminUserRead(**user)
103-
except Exception:
104-
raise UnauthorizedException("Invalid user data")
104+
except Exception as e:
105+
raise UnauthorizedException("Invalid user data") from e
105106
elif not isinstance(user, AdminUserRead):
106107
try:
107108
user = AdminUserRead.from_orm(user)
108-
except Exception:
109-
raise UnauthorizedException("Invalid user data")
109+
except Exception as e:
110+
raise UnauthorizedException("Invalid user data") from e
110111
return user
111112

112113
logger.debug("User not found")

crudadmin/admin_interface/crud_admin.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,43 @@
1+
import logging
12
import os
23
import time
3-
import logging
4+
from datetime import datetime, timedelta, timezone
45
from typing import (
5-
TypeVar,
6-
Type,
7-
Dict,
86
Any,
9-
Union,
10-
Optional,
11-
List,
12-
Callable,
137
Awaitable,
14-
cast,
8+
Callable,
9+
Dict,
10+
List,
11+
Optional,
12+
Type,
1513
TypedDict,
14+
TypeVar,
15+
Union,
16+
cast,
1617
)
17-
from datetime import datetime, timezone, timedelta
1818

19-
from fastapi import APIRouter, FastAPI, Depends, Request
20-
from fastapi.templating import Jinja2Templates
19+
from fastapi import APIRouter, Depends, FastAPI, Request
2120
from fastapi.security import OAuth2PasswordBearer
2221
from fastapi.staticfiles import StaticFiles
22+
from fastapi.templating import Jinja2Templates
2323
from fastcrud import FastCRUD
2424
from pydantic import BaseModel
2525
from sqlalchemy import text
2626
from sqlalchemy.ext.asyncio import AsyncSession
2727
from sqlalchemy.orm import DeclarativeBase
2828
from typing_extensions import TypeAlias
2929

30-
from .model_view import ModelView
31-
from .admin_site import AdminSite
32-
from .typing import RouteResponse
3330
from ..admin_interface.auth import AdminAuthentication
3431
from ..admin_interface.middleware.auth import AdminAuthMiddleware
3532
from ..admin_interface.middleware.ip_restriction import IPRestrictionMiddleware
36-
from ..session import create_admin_session_model, SessionManager
3733
from ..admin_token.service import TokenService
38-
from ..admin_user.service import AdminUserService
39-
from ..core.db import DatabaseConfig, AdminBase
4034
from ..admin_user.schemas import AdminUserCreate, AdminUserCreateInternal
35+
from ..admin_user.service import AdminUserService
36+
from ..core.db import AdminBase, DatabaseConfig
37+
from ..session import SessionManager, create_admin_session_model
38+
from .admin_site import AdminSite
39+
from .model_view import ModelView
40+
from .typing import RouteResponse
4141

4242
logger = logging.getLogger("crudadmin")
4343

@@ -326,7 +326,7 @@ def __init__(
326326

327327
self.app.add_middleware(AdminAuthMiddleware, admin_instance=self)
328328

329-
from ..event import create_admin_event_log, create_admin_audit_log
329+
from ..event import create_admin_audit_log, create_admin_event_log
330330

331331
event_log_model: Optional[Type[DeclarativeBase]] = None
332332
audit_log_model: Optional[Type[DeclarativeBase]] = None
@@ -514,7 +514,7 @@ async def event_log_page_inner(
514514
admin_db: AsyncSession = Depends(admin_db_db_dependency),
515515
app_db: AsyncSession = Depends(app_db_dependency),
516516
) -> RouteResponse:
517-
from ..event import EventType, EventStatus
517+
from ..event import EventStatus, EventType
518518

519519
users = await self.db_config.crud_users.get_multi(db=app_db)
520520

crudadmin/admin_interface/helper.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
from typing import get_origin, Dict, Any, Type, List, TypeVar, cast
21
from datetime import date, datetime, time
32
from decimal import Decimal
43
from enum import Enum
4+
from typing import Any, Dict, List, Type, TypeVar, cast, get_origin
55

6-
from pydantic import BaseModel, EmailStr, HttpUrl, AnyHttpUrl
6+
from pydantic import AnyHttpUrl, BaseModel, EmailStr, HttpUrl
77

88
T = TypeVar("T")
99
HTMLInputType = tuple[str, Dict[str, Any]]

crudadmin/admin_interface/middleware/auth.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
from typing import TYPE_CHECKING
21
import logging
2+
from typing import TYPE_CHECKING
33

44
from fastapi import FastAPI, Request
55
from fastapi.responses import RedirectResponse

crudadmin/admin_interface/middleware/https.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from fastapi import Request
2-
from starlette.middleware.base import BaseHTTPMiddleware
32
from fastapi.responses import RedirectResponse
3+
from starlette.middleware.base import BaseHTTPMiddleware
44

55

66
class HTTPSRedirectMiddleware(BaseHTTPMiddleware):

crudadmin/admin_interface/middleware/ip_restriction.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
1-
from typing import List, Optional
1+
import logging
22
from ipaddress import ip_address, ip_network
3+
from typing import List, Optional
4+
35
from fastapi import Request
6+
from fastapi.responses import JSONResponse
47
from starlette.middleware.base import BaseHTTPMiddleware
58
from starlette.types import ASGIApp
6-
from fastapi.responses import JSONResponse
7-
import logging
89

910
logger = logging.getLogger(__name__)
1011

crudadmin/admin_interface/model_view.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
1+
import datetime
2+
from datetime import timezone
13
from typing import (
2-
TypeVar,
3-
Type,
4-
List,
5-
Optional,
64
Any,
5+
AsyncGenerator,
76
Callable,
7+
Coroutine,
88
Dict,
9+
List,
10+
Optional,
911
Set,
10-
cast,
11-
Coroutine,
12-
AsyncGenerator,
12+
Type,
13+
TypeVar,
1314
Union,
15+
cast,
1416
)
15-
import datetime
16-
from datetime import timezone
1717

18-
from fastapi import APIRouter, Request, Depends, UploadFile
18+
from fastapi import APIRouter, Depends, Request, UploadFile
19+
from fastapi.responses import JSONResponse, RedirectResponse, Response
1920
from fastapi.templating import Jinja2Templates
20-
from fastapi.responses import RedirectResponse, JSONResponse, Response
21+
from fastcrud import EndpointCreator, FastCRUD
2122
from pydantic import BaseModel, ValidationError
23+
from sqlalchemy import inspect
2224
from sqlalchemy.ext.asyncio import AsyncSession
2325
from sqlalchemy.orm import DeclarativeBase
24-
from sqlalchemy import inspect
25-
from fastcrud import FastCRUD, EndpointCreator
2626

2727
from ..core.db import DatabaseConfig
28-
from ..event import log_admin_action, EventType
28+
from ..event import EventType, log_admin_action
2929
from .helper import _get_form_fields_from_schema
3030

3131
EndpointCallable = Callable[..., Coroutine[Any, Any, Response]]
@@ -45,7 +45,7 @@ class BulkDeleteRequest(BaseModel):
4545

4646

4747
class ModelView:
48-
"""
48+
r"""
4949
View class for managing CRUD operations and UI for database models in FastAPI admin interface.
5050
5151
Features:
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
from typing import Union
22

3-
from starlette.templating import _TemplateResponse
43
from fastapi import Response
54
from fastapi.responses import RedirectResponse
6-
5+
from starlette.templating import _TemplateResponse
76

87
RouteResponse = Union[Response, RedirectResponse, _TemplateResponse]

crudadmin/admin_token/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
from .models import create_admin_token_blacklist
22
from .schemas import (
33
AdminToken,
4-
AdminTokenData,
54
AdminTokenBlacklistBase,
65
AdminTokenBlacklistCreate,
76
AdminTokenBlacklistUpdate,
7+
AdminTokenData,
88
)
99
from .service import TokenService
1010

0 commit comments

Comments
 (0)