Skip to content

Commit 1bb355b

Browse files
committed
max_sample_size changelog and README docs
1 parent 8aa65e4 commit 1bb355b

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## Unreleased
99

10+
## Features (User Facing)
11+
* Introduce `max_sample_size` which guides how many samples will be gathered at most for a given scenario. This avoids a variety of issues when scenarios gather too many samples (memory consumption etc). Defaults to `1_000_000`, setting it to `nil` gathers unlimited samples again (behavior before this version).
12+
1013
### Bugfixes (User Facing)
1114
* fix a bug where if times were supplied as `0` instead of `0.0` we'd sometimes gather a single measurement
1215

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -259,6 +259,10 @@ The available options are the following (also documented in [hexdocs](https://he
259259
[`:eprof`](https://hexdocs.pm/mix/Mix.Tasks.Profile.Eprof.html)
260260
[`:fprof`](https://hexdocs.pm/mix/Mix.Tasks.Profile.Fprof.html) and
261261
[`:tprof`](https://hexdocs.pm/mix/Mix.Tasks.Profile.Tprof.html) (requires elixir >= 1.17 and erlang >= 27).
262+
* `max_sample_size` - the maximum number of samples collected per scenario. Defaults to `1_000_000`.
263+
This is used to limit memory consumption and unnecessary processing - 1 Million samples is plenty.
264+
This limit also applies to number of iterations done during warmup.
265+
You can set your own number or set it to `nil` if you don't want any limit.
262266

263267
### Metrics to measure
264268

0 commit comments

Comments
 (0)