Skip to content

Commit eedd084

Browse files
committed
cli_resource_id
1 parent d92577c commit eedd084

File tree

53 files changed

+128
-122
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+128
-122
lines changed

lib/bencher_client/src/lib.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -253,19 +253,18 @@ from_slug!(
253253
BranchSlug,
254254
TestbedSlug,
255255
BenchmarkSlug,
256-
MeasureSlug,
257-
UserSlug
256+
MeasureSlug
258257
);
259258

260259
macro_rules! from_resource_id {
261260
($($from:ident),*) => {
262261
$(
263262
impl From<bencher_json::$from> for types::ResourceId {
264263
fn from(json: bencher_json::$from) -> Self {
265-
match json {
266-
bencher_json::$from::Uuid(uuid) => Self::Uuid(uuid.into()),
267-
bencher_json::$from::Slug(slug) => Self::Slug(slug.into()),
268-
}.into()
264+
types::Slug::from(match json {
265+
bencher_json::$from::Uuid(uuid) => uuid.to_string(),
266+
bencher_json::$from::Slug(slug) => slug.to_string(),
267+
}).into()
269268
}
270269
}
271270
)*

lib/bencher_valid/src/slug.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,12 @@ pub struct Slug(String);
2424
#[cfg(feature = "db")]
2525
crate::typed_string!(Slug);
2626

27+
impl From<uuid::Uuid> for Slug {
28+
fn from(uuid: uuid::Uuid) -> Self {
29+
Self(uuid.to_string())
30+
}
31+
}
32+
2733
impl FromStr for Slug {
2834
type Err = ValidError;
2935

services/cli/src/bencher/sub/organization/member/view.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use bencher_json::OrganizationResourceId;
1+
use bencher_json::{OrganizationResourceId, UserResourceId};
22

33
use crate::{
44
CliError,

services/cli/src/bencher/sub/project/archive/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use bencher_json::ResourceId;
1+
use bencher_json::ProjectResourceId;
22

33
use crate::{
44
CliError,
@@ -14,7 +14,7 @@ use dimension::Dimension;
1414

1515
#[derive(Debug, Clone)]
1616
pub struct Archive {
17-
pub project: ResourceId,
17+
pub project: ProjectResourceId,
1818
pub dimension: Dimension,
1919
pub action: ArchiveAction,
2020
pub backend: AuthBackend,

services/cli/src/bencher/sub/project/benchmark/create.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use bencher_client::types::JsonNewBenchmark;
2-
use bencher_json::{BenchmarkName, BenchmarkSlug, ResourceId};
2+
use bencher_json::{BenchmarkName, BenchmarkSlug, ProjectResourceId};
33

44
use crate::{
55
CliError,
@@ -9,7 +9,7 @@ use crate::{
99

1010
#[derive(Debug, Clone)]
1111
pub struct Create {
12-
pub project: ResourceId,
12+
pub project: ProjectResourceId,
1313
pub name: BenchmarkName,
1414
pub slug: Option<BenchmarkSlug>,
1515
pub backend: AuthBackend,

services/cli/src/bencher/sub/project/benchmark/delete.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use bencher_json::ResourceId;
1+
use bencher_json::{BenchmarkResourceId, ProjectResourceId};
22

33
use crate::{
44
CliError,
@@ -8,8 +8,8 @@ use crate::{
88

99
#[derive(Debug)]
1010
pub struct Delete {
11-
pub project: ResourceId,
12-
pub benchmark: ResourceId,
11+
pub project: ProjectResourceId,
12+
pub benchmark: BenchmarkResourceId,
1313
pub backend: AuthBackend,
1414
}
1515

services/cli/src/bencher/sub/project/benchmark/list.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use bencher_client::types::{JsonDirection, ProjBenchmarksSort};
2-
use bencher_json::{BenchmarkName, ResourceId};
2+
use bencher_json::{BenchmarkName, ProjectResourceId};
33

44
use crate::{
55
CliError,
@@ -12,7 +12,7 @@ use crate::{
1212

1313
#[derive(Debug)]
1414
pub struct List {
15-
pub project: ResourceId,
15+
pub project: ProjectResourceId,
1616
pub name: Option<BenchmarkName>,
1717
pub search: Option<String>,
1818
pub pagination: Pagination,

services/cli/src/bencher/sub/project/benchmark/update.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use bencher_client::types::JsonUpdateBenchmark;
2-
use bencher_json::{BenchmarkName, BenchmarkSlug, ResourceId};
2+
use bencher_json::{BenchmarkName, BenchmarkResourceId, BenchmarkSlug, ProjectResourceId};
33

44
use crate::{
55
CliError,
@@ -9,8 +9,8 @@ use crate::{
99

1010
#[derive(Debug, Clone)]
1111
pub struct Update {
12-
pub project: ResourceId,
13-
pub benchmark: ResourceId,
12+
pub project: ProjectResourceId,
13+
pub benchmark: BenchmarkResourceId,
1414
pub name: Option<BenchmarkName>,
1515
pub slug: Option<BenchmarkSlug>,
1616
pub archived: Option<bool>,

services/cli/src/bencher/sub/project/benchmark/view.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use bencher_json::ResourceId;
1+
use bencher_json::{BenchmarkResourceId, ProjectResourceId};
22

33
use crate::{
44
CliError,
@@ -8,8 +8,8 @@ use crate::{
88

99
#[derive(Debug)]
1010
pub struct View {
11-
pub project: ResourceId,
12-
pub benchmark: ResourceId,
11+
pub project: ProjectResourceId,
12+
pub benchmark: BenchmarkResourceId,
1313
pub backend: PubBackend,
1414
}
1515

services/cli/src/bencher/sub/project/branch/create.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use bencher_client::types::{JsonNewBranch, JsonNewStartPoint};
2-
use bencher_json::{BranchName, BranchNameId, BranchSlug, GitHash, ResourceId};
2+
use bencher_json::{BranchName, BranchNameId, BranchSlug, GitHash, ProjectResourceId};
33

44
use crate::{
55
CliError,
@@ -9,7 +9,7 @@ use crate::{
99

1010
#[derive(Debug, Clone)]
1111
pub struct Create {
12-
pub project: ResourceId,
12+
pub project: ProjectResourceId,
1313
pub name: BranchName,
1414
pub slug: Option<BranchSlug>,
1515
pub start_point_branch: Option<BranchNameId>,

0 commit comments

Comments
 (0)