minor code improvements

Author: ktrz

src/extractRangeInfo.ts

@@ -5,11 +5,11 @@ export function extractRangeInfo(range: string | undefined): { prefix: string; v
 
     const matches = range.match(/(?<prefix>(\+-|±)\s*)(?<value>\d.+)/);
 
-    if (!matches) {
+    if (!matches || !matches.groups) {
         return undefined;
     }
 
-    const valueString = matches.groups?.['value'];
+    const valueString = matches.groups.value;
 
     const value = Number(valueString);
 
@@ -19,6 +19,6 @@ export function extractRangeInfo(range: string | undefined): { prefix: string; v
 
     return {
         value,
-        prefix: matches.groups?.prefix ?? '',
+        prefix: matches.groups.prefix ?? '',
     };
 }

src/normalizeUnit.ts

@@ -6,13 +6,14 @@ export function normalizeUnit(prevUnit: string, currentUnit: string, value: numb
         if (prevUnitIndex >= 0 && currentUnitIndex >= 0) {
             const unitDiff = prevUnitIndex - currentUnitIndex;
 
-            return value * 1000 ** unitDiff;
+            return value * UNIT_CONVERSION_MULTIPLIER ** unitDiff;
         }
     }
 
     return value;
 }
 
+const UNIT_CONVERSION_MULTIPLIER = 1000;
 const TIME_UNITS = ['s', 'ms', 'us', 'ns'];
 const ITER_UNITS = TIME_UNITS.map((unit) => `${unit}/iter`);
 const OPS_PER_TIME_UNIT = [...TIME_UNITS].reverse().map((unit) => `ops/${unit}`);

test/extractRangeInfo.spec.ts

@@ -24,5 +24,7 @@ describe('extractRangeInfo', () => {
     it('should NOT extract range with invalid number', () => {
         expect(extractRangeInfo('± boo')).toBeUndefined();
         expect(extractRangeInfo('+- boo')).toBeUndefined();
+        expect(extractRangeInfo('± 1boo')).toBeUndefined();
+        expect(extractRangeInfo('+- 1boo')).toBeUndefined();
     });
 });