Skip to content

Sort benchmark graphs and PR comments by the git-graph #3769

@stuhood

Description

@stuhood

What feature are you requesting?

Without awareness of the git-graph, it is impossible to know which commit is "most recent" on a particular release branch.

Our benchmarks (https://paradedb.github.io/paradedb/benchmarks/) currently sort by commit time, which means that recording new data for a release branch (e.g. 0.20.x) will be inserted at a time-based position in the graph, causing it to be intermingled with data for main.

The Github action that we use to maintain the benchmark graphs also posts PR comments, and since it is not git-graph aware, the "most recent" commit that it will compare to will always be whichever was inserted into the data most recently. When posting a comment in a PR on 0.20.x, this will likely be a commit from main, even though the best comparable commit would be the most recent commit on 0.20.x.

Why are you requesting this feature?

Because of the above problem, we currently only record benchmark data on main. Although release branches support kicking off the benchmarks on PRs, they will always compare to the data recorded by main.

What is your proposed implementation for this feature?

We should adjust the action to use the git-graph to:

  1. sort the datapoints in the benchmark graphs
  2. find the "most-recent" commit for a PR comparison

These may be the same operation, depending on how the action is implemented.

Full Name:

Stu Hood

Affiliation:

ParadeDB

Metadata

Metadata

Assignees

Labels

ci/testsIssue related to our CI and/or testing frameworksfeatureNew feature or requestpriority-mediumMedium priority issue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions