Merge branch 'main' of github.com:benjamaan476/egakeru

Author: benjamaan476

engine/platform/windows/platform_windows.cpp

@@ -186,7 +186,7 @@ namespace egkr
 		return { (uint32_t)width_, (uint32_t)height_ };
 	}
 
-	std::optional<platform::dynamic_library internal_platform::load_library(const std::string& library_name)
+	std::optional<platform::dynamic_library> internal_platform::load_library(const std::string& library_name)
 	{
 		if(library_name.empty())
 		{
@@ -232,7 +232,7 @@ namespace egkr
 			return false;
 		}
 
-		FARPROC addr = GetProcAddress((HMODULE)library.interal_data, function_name.c_str());
+		FARPROC addr = GetProcAddress((HMODULE)library.internal_data, function_name.c_str());
 		if(!addr)
 		{
 			LOG_ERROR("Could not load function {} from {}", function_name, library.library_name);

engine/platform/windows/platform_windows.h

@@ -28,8 +28,8 @@ namespace egkr
 		[[nodiscard]] void* get_window() const override;
 		uint2 get_framebuffer_size() final;
 		[[nodiscard]] static std::optional<dynamic_library> load_library(const std::string& library_name);
-		bool unload_library(dynamic_library& library);
-		bool load_function(const std::string& function_name, dynamic_library& library);
+		static bool unload_library(dynamic_library& library);
+		static bool load_function(const std::string& function_name, dynamic_library& library);
 
 	private:
 

engine/plugins/renderer/vulkan/renderer_vulkan.cpp

@@ -182,7 +182,7 @@ namespace egkr
 	    requirements.transfer = true;
 	    requirements.sampler_anisotropy = true;
 
-	    requirements.discrete_gpu = true;
+	    requirements.discrete_gpu = false;
 
 	    physical_device_queue_family_info queue_info{};
 

engine/renderer/passes/scene_pass.cpp

@@ -127,7 +127,7 @@ namespace egkr::pass
 		{
 		    const auto& model = world->get_world();
 		    shader_system::set_uniform(terrain_shader_locations.model, &model);
-		};
+		}
 	    }
 
 	    if (data.terrain.front().is_winding_reversed)

engine/systems/font_system.cpp

@@ -309,7 +309,7 @@ namespace egkr
 		}
 		variant.glyphs.reserve(codepoint_count);
 
-		for(const auto& [i, pc] : packed_chars | std::views::enumerate)
+		for(const auto[i, pc] : packed_chars | std::views::enumerate)
 		{
 			const font::glyph glyph
 			{
@@ -342,7 +342,7 @@ namespace egkr
 					return {};
 				}
 
-				for(const auto& [table, kern] : std::views::zip(kerning_table, variant.kernings))
+				for(const auto [table, kern] : std::views::zip(kerning_table, variant.kernings))
 				{
 					kern.codepoint_0 = table.glyph1;
 					kern.codepoint_1 = table.glyph2;

engine/systems/geometry_utils.h

@@ -71,7 +71,7 @@ template <typename vertex> [[maybe_unused]] static void generate_tangents(egkr::
     }
 }
 
-template <typename vertex> static void generate_normals(egkr::vector<vertex>& vertices, const egkr::vector<uint32_t>& indices)
+template <typename vertex> [[maybe_unused]] static void generate_normals(egkr::vector<vertex>& vertices, const egkr::vector<uint32_t>& indices)
 {
     for (auto i{0U}; i < indices.size(); i += 3)
     {