Merge pull request #17 from benjamaan476/viewport

Viewport

Author: benjamaan476

.clang-tidy

@@ -20,7 +20,10 @@ Checks: "*,
         -hicpp-signed-bitwise,
         -cppcoreguidelines-pro-bounds-pointer-arithmetic,
         -cppcoreguidelines-pro-type-cstyle-cast,
+        -cppcoreguidelines-pro-type-union-access,
         -missing-field-initializers,
+        -hicpp-uppercase-literal-suffix,
+        -cppcoreguidlines-avoid-magic-numbers,
 "
 WarningsAsErrors: ''
 HeaderFilterRegex: ''

.gitignore

@@ -6,6 +6,7 @@ conan-cache/
 
 # User spesific settings
 CMakeUserPresets.json
+compile_commands.json
 
 # IDE files
 .vs/
@@ -34,3 +35,5 @@ ehthumbs.db
 Thumbs.db
 *.spv
 .cache
+
+compile_commands.json

CMakeLists.txt

@@ -5,9 +5,7 @@ cmake_minimum_required(VERSION 3.21)
 # manual dependency management
 
 # Only set the cxx_standard if it is not set by someone else
-if (NOT DEFINED CMAKE_CXX_STANDARD)
   set(CMAKE_CXX_STANDARD 23)
-endif()
 
 # strongly encouraged to enable this globally to avoid conflicts between
 # -Wpedantic being enabled and -std=c++20 and -std=gnu++20 for example
@@ -64,7 +62,13 @@ if(DEFINED TRACY_ENABLE)
 add_subdirectory (tracy)
 endif()
 
-add_definitions(-DENABLE_DEBUG_MACRO)
+if(CMAKE_BUILD_TYPE EQUAL "Debug")
+  add_definitions(-DENABLE_DEBUG_MACRO)
+endif()
+
+if(MSVC)
+    add_definitions(-D_CRT_SECURE_NO_WARNINGS)
+endif()
 
 # Adding the src:
 add_subdirectory(engine)

CMakePresets.json

@@ -139,7 +139,7 @@
         },
         {
             "name": "unixlike-gcc-debug",
-            "displayName": "gcc Debug",
+            "displayName": "unix gcc Debug",
             "description": "Target Unix-like OS with the gcc compiler, debug build type",
             "inherits": "conf-unixlike-common",
             "cacheVariables": {
@@ -150,7 +150,7 @@
         },
         {
             "name": "unixlike-gcc-release",
-            "displayName": "gcc Release",
+            "displayName": "unix gcc Release",
             "description": "Target Unix-like OS with the gcc compiler, release build type",
             "inherits": "conf-unixlike-common",
             "cacheVariables": {
@@ -161,7 +161,7 @@
         },
         {
             "name": "unixlike-clang-debug",
-            "displayName": "clang Debug",
+            "displayName": "unix clang Debug",
             "description": "Target Unix-like OS with the clang compiler, debug build type",
             "inherits": "conf-unixlike-common",
             "cacheVariables": {
@@ -172,7 +172,7 @@
         },
         {
             "name": "unixlike-clang-release",
-            "displayName": "clang Release",
+            "displayName": "unix clang Release",
             "description": "Target Unix-like OS with the clang compiler, release build type",
             "inherits": "conf-unixlike-common",
             "cacheVariables": {
@@ -252,4 +252,4 @@
             "configurePreset": "unixlike-clang-release"
         }
     ]
-}
+}

ProjectOptions.cmake

@@ -15,6 +15,9 @@ macro(egakeru_supports_sanitizers)
   else()
     set(SUPPORTS_ASAN ON)
   endif()
+
+  set(SUPPORTS_ASAN OFF)
+  set(SUPPORTS_UBSAN OFF)
 endmacro()
 
 macro(egakeru_setup_options)
@@ -55,7 +58,7 @@ macro(egakeru_setup_options)
     option(egakeru_ENABLE_UNITY_BUILD "Enable unity builds" OFF)
     option(egakeru_ENABLE_CLANG_TIDY "Enable clang-tidy" OFF)
     option(egakeru_ENABLE_CPPCHECK "Enable cpp-check analysis" ON)
-    option(egakeru_ENABLE_PCH "Enable precompiled headers" ON)
+    option(egakeru_ENABLE_PCH "Enable precompiled headers" OFF)
     option(egakeru_ENABLE_CACHE "Enable ccache" OFF)
   endif()
 

assets/meshes/output.esm

@@ -64,16 +64,16 @@ function(
         -Wno-exit-time-destructors
         -Wno-global-constructors
         -Wno-covered-switch-default
-        -Wno-unsafe-buffer-usage
         -Wno-switch-enum
         -Wno-disabled-macro-expansion
-        -Wno-cast-function-type-strict
         -Wno-implicit-int-float-conversion
         -Wno-ctad-maybe-unsupported
         -Wno-c++20-compat
         -Wno-deprecated-copy-with-user-provided-dtor
         -Wno-cast-align
         -Wno-vla-extension
+        -Wno-unsafe-buffer-usage
+        -Wno-cast-function-type-strict
     )
   endif()
 

cmake/CompilerWarnings.cmake

@@ -1 +1 @@
-/home/bencrabbe/code/egakeru/out/build/unixlike-clang-release/compile_commands.json
+/home/bencrabbe/code/egakeru/out/build/unixlike-clang-debug/compile_commands.json

compile_commands.json

@@ -16,15 +16,15 @@ namespace egkr
 	class application
 	{
 	public:
-
 		using unique_ptr = std::unique_ptr<application>;
 		API explicit application(engine_configuration configuration);
 
 		API virtual ~application()  = default;
 
 		virtual bool init() = 0;
 		virtual void update(const frame_data& frame_data) = 0;
-		virtual void render(render_packet* render_packet, const frame_data& frame_data) = 0;
+		virtual void prepare_render_packet(render_packet* render_packet, const frame_data& frame_data) = 0;
+		virtual void render(egkr::render_packet* render_packet, egkr::frame_data& frame_data) = 0;
 		virtual bool resize(uint32_t width, uint32_t height) = 0;
 
 		virtual bool boot() = 0;

engine/application/application.h

@@ -9,7 +9,7 @@ namespace egkr::debug
 
 	debug_grid::debug_grid(const configuration& configuration)
 		: name_{ configuration.name },
-		orientation_{ configuration.orientation },
+		orientation_{ configuration.grid_orientation },
 		tile_count_dim0_{ configuration.tile_count_dim0 },
 		tile_count_dim1_{ configuration.tile_count_dim1 },
 		tile_scale_{ configuration.tile_scale }
@@ -146,11 +146,8 @@ namespace egkr::debug
 
 	}
 
-	debug_grid::~debug_grid()
-	{
-	}
 
-	bool debug_grid::load()
+        bool debug_grid::load()
 	{
 		geometry::properties properties{};
 		properties.name = "degug_grid";