Skip to content

fix support of unquoted value on time criteria #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix support of unquoted value on time criteria #10

wants to merge 9 commits into from

Conversation

fifthaxe
Copy link

influxql permits to set an unquoted string for a timestamp :
time >= 12ms

this PR adds support to this case

@coveralls
Copy link

coveralls commented Dec 20, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 71

  • 2 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.2%) to 98.758%
Changes Missing Coverage Covered Lines Changed/Added Lines %
query_builder.go 2 6 33.33%
Totals Coverage Status
Change from base Build 65: -1.2%
Covered Lines: 318
Relevant Lines: 322
💛 - Coveralls

@benjamin658
Copy link
Owner

Thanks for your contribution, it would be great to add unit test on it, after the test passed, I will merge the PR, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fifthaxe @coveralls @benjamin658