Skip to content

Commit c236f48

Browse files
refactor: simplify sign-in method by removing outdated authentication options
1 parent 0c172f0 commit c236f48

File tree

4 files changed

+96
-13
lines changed

4 files changed

+96
-13
lines changed
Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: '[BUG] '
5+
labels: bug
6+
assignees: ''
7+
---
8+
9+
## Describe the bug
10+
11+
A clear and concise description of what the bug is.
12+
13+
## Environment
14+
15+
- **React Native version**: <!-- e.g. 0.71.0 -->
16+
- **Library version**: <!-- e.g. 1.0.0 -->
17+
- **Platform**: <!-- iOS, Android, or both -->
18+
- **Device information**:
19+
- iOS: <!-- e.g. iPhone 14 Pro, iOS 16.2 (physical) OR iPhone 13 Simulator, iOS 15.5 -->
20+
- Android: <!-- e.g. Pixel 6, Android 12 (physical) OR Pixel 4 Emulator, Android 11 -->
21+
22+
## Steps to Reproduce
23+
24+
1.
25+
2.
26+
3.
27+
28+
## Expected behavior
29+
30+
A clear and concise description of what you expected to happen.
31+
32+
## Actual behavior
33+
34+
A clear and concise description of what actually happened.
35+
36+
## Screenshots
37+
38+
If applicable, add screenshots to help explain your problem.
39+
40+
## Code snippet
41+
42+
```javascript
43+
// Add a minimal code example that demonstrates the issue
44+
```
45+
46+
## Additional context
47+
48+
- Have you tried on both physical device and simulator/emulator?
49+
- Have you tested on the latest library version?
50+
- Any other relevant information about your setup

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Question or Discussion
4+
url: https://github.com/username/react-native-credentials-manager/discussions
5+
about: Please ask and answer questions here.
6+
- name: Documentation
7+
url: https://github.com/username/react-native-credentials-manager#readme
8+
about: Make sure you've read the documentation before filing an issue.
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: '[FEATURE] '
5+
labels: enhancement
6+
assignees: ''
7+
---
8+
9+
## Is your feature request related to a problem? Please describe.
10+
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
## Describe the solution you'd like
14+
15+
A clear and concise description of what you want to happen.
16+
17+
## Describe alternatives you've considered
18+
19+
A clear and concise description of any alternative solutions or features you've considered.
20+
21+
## Environment (if relevant)
22+
23+
- **React Native version**: <!-- e.g. 0.71.0 -->
24+
- **Platform**: <!-- iOS, Android, or both -->
25+
26+
## Additional context
27+
28+
Add any other context or screenshots about the feature request here.

example/src/App.tsx

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -54,19 +54,16 @@ export default function App() {
5454
// Use the helper to generate a valid authentication request
5555
const validAuthRequest = generateTestAuthenticationRequest();
5656

57-
const credential = await signIn(
58-
['passkeys', 'password', 'apple-signin'],
59-
{
60-
passkeys: validAuthRequest,
61-
googleSignIn: {
62-
serverClientId: WEB_CLIENT_ID,
63-
autoSelectEnabled: true,
64-
},
65-
appleSignIn: {
66-
requestedScopes: ['fullName', 'email'],
67-
},
68-
}
69-
);
57+
const credential = await signIn(['google-signin'], {
58+
passkeys: validAuthRequest,
59+
googleSignIn: {
60+
serverClientId: WEB_CLIENT_ID,
61+
autoSelectEnabled: true,
62+
},
63+
appleSignIn: {
64+
requestedScopes: ['fullName', 'email'],
65+
},
66+
});
7067

7168
if (credential.type === 'passkey') {
7269
console.log('Passkey:', credential.authenticationResponseJson);

0 commit comments

Comments
 (0)