fix: change googleSignin function name for bettter clarity

Author: benjamineruvieru

android/src/newarch/java/com/credentialsmanager/CredentialsManagerModule.kt

@@ -90,7 +90,7 @@ class CredentialsManagerModule(
     }
   }
 
-  override fun signInWithGoogle(
+  override fun signUpWithGoogle(
     requestObject: ReadableMap,
     promise: Promise,
   ) {

android/src/oldarch/java/com/credentialsmanager/CredentialsManagerModule.kt

@@ -62,17 +62,35 @@ class CredentialsManagerModule(
   }
 
   @ReactMethod
-  fun signInWithSavedCredentials(
-    requestJson: ReadableMap,
+   fun signIn(
+    options: ReadableArray,
+    params: ReadableMap,
     promise: Promise,
   ) {
-    val jsonString = requestJson.toString()
     coroutineScope.launch {
-      val data = credentialHandler.getSavedCredentials(jsonString)
-      promise.resolve(data)
+      try {
+        val data = credentialHandler.signIn(options = options, params = params)
+        promise.resolve(data)
+      } catch (e: GetCredentialException) {
+        Log.e("CredentialManager", "Error during sign out", e)
+        promise.reject("ERROR", e.message.toString())
+      }
     }
   }
 
+
+  // @ReactMethod
+  // fun signInWithSavedCredentials(
+  //   requestJson: ReadableMap,
+  //   promise: Promise,
+  // ) {
+  //   val jsonString = requestJson.toString()
+  //   coroutineScope.launch {
+  //     val data = credentialHandler.getSavedCredentials(jsonString)
+  //     promise.resolve(data)
+  //   }
+  // }
+
   @ReactMethod
   fun signOut(promise: Promise) {
     coroutineScope.launch {
@@ -87,7 +105,7 @@ class CredentialsManagerModule(
   }
 
   @ReactMethod
-  fun signInWithGoogle(
+  fun signUpWithGoogle(
     requestObject: ReadableMap,
     promise: Promise,
   ) {

example/src/App.tsx

@@ -2,7 +2,7 @@ import { View, StyleSheet, Button } from 'react-native';
 import {
   signUpWithPasskeys,
   signUpWithPassword,
-  signInWithGoogle,
+  signUpWithGoogle,
   signOut,
   signIn,
 } from 'react-native-credentials-manager';
@@ -109,10 +109,10 @@ export default function App() {
       />
 
       <Button
-        title="Signin With Google"
+        title="SignUp With Google"
         onPress={async () => {
           try {
-            const credential = await signInWithGoogle({
+            const credential = await signUpWithGoogle({
               serverClientId: WEB_CLIENT_ID,
               autoSelectEnabled: true,
             });

src/NativeCredentialsManager.ts

@@ -55,7 +55,7 @@ export interface Spec extends TurboModule {
       googleSignIn?: GoogleSignInParams;
     }
   ): Promise<Credential>;
-  signInWithGoogle(params: GoogleSignInParams): Promise<GoogleCredential>;
+  signUpWithGoogle(params: GoogleSignInParams): Promise<GoogleCredential>;
   signOut(): Promise<null>;
 }
 

src/index.tsx

@@ -48,10 +48,10 @@ export function signIn(
   });
 }
 
-export function signInWithGoogle(
+export function signUpWithGoogle(
   params: GoogleSignInParams
 ): Promise<GoogleCredential> {
-  return CredentialsManager.signInWithGoogle({
+  return CredentialsManager.signUpWithGoogle({
     ...params,
     nonce: params.nonce ?? '',
     autoSelectEnabled: params.autoSelectEnabled ?? true,