Skip to content

Commit bfedbc2

Browse files
committed
[TASK] Cleanup backend form module JavaScript migration
* Require at least TYPO3 v12.4.5 as a bug was present until v12.4.4 https://review.typo3.org/c/Packages/TYPO3.CMS/+/80174 * Remove jquery requirement * Use instanciated stage module (like the core does as well) * Use array unfolding to make generic args array elements readable without requiring doc comments * Avoid unneeded doc comments
1 parent 32c1e1d commit bfedbc2

File tree

3 files changed

+11
-45
lines changed

3 files changed

+11
-45
lines changed
Lines changed: 9 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,14 @@
1-
/**
2-
* Module: @bk2k/bootstrap-package/backend/form-editor/grid-column-view-model.js
3-
*/
4-
5-
import $ from 'jquery';
6-
import * as StageComponent from '@typo3/form/backend/form-editor/stage-component.js';
7-
8-
/**
9-
* @private
10-
*
11-
* @return object
12-
*/
13-
function getPublisherSubscriber(formEditorApp) {
14-
return formEditorApp.getPublisherSubscriber();
15-
}
16-
17-
/**
18-
* @private
19-
*
20-
* @return void
21-
*/
22-
function subscribeEvents(formEditorApp) {
23-
/**
24-
* @private
25-
*
26-
* @param string
27-
* @param array
28-
* args[0] = formElement
29-
* args[1] = template
30-
* @return void
31-
* @subscribe view/stage/abstract/render/template/perform
32-
*/
33-
getPublisherSubscriber(formEditorApp).subscribe('view/stage/abstract/render/template/perform', function (topic, args) {
34-
if (args[0].get('type') === 'GridColumn') {
35-
StageComponent.renderCheckboxTemplate(args[0], args[1]);
1+
function subscribeEvents(formEditor) {
2+
formEditor.getPublisherSubscriber().subscribe('view/stage/abstract/render/template/perform', (
3+
topic,
4+
[formElement, template]
5+
) => {
6+
if (formElement.get('type') === 'GridColumn') {
7+
formEditor.getViewModel().getStage().renderSimpleTemplateWithValidators(formElement, template);
368
}
379
});
38-
}
10+
};
3911

40-
/**
41-
* @public
42-
*
43-
* @param object formEditorApp
44-
* @return void
45-
*/
4612
export function bootstrap(formEditorApp) {
4713
subscribeEvents(formEditorApp);
48-
}
14+
};

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"typo3/cms-belog": "^12.4 || ^13.4 || 13.*.*@dev",
5757
"typo3/cms-felogin": "^12.4 || ^13.4 || 13.*.*@dev",
5858
"typo3/cms-filelist": "^12.4 || ^13.4 || 13.*.*@dev",
59-
"typo3/cms-form": "^12.4 || ^13.4 || 13.*.*@dev",
59+
"typo3/cms-form": "^12.4.5 || ^13.4 || 13.*.*@dev",
6060
"typo3/cms-indexed-search": "^12.4 || ^13.4 || 13.*.*@dev",
6161
"typo3/cms-info": "^12.4 || ^13.4 || 13.*.*@dev",
6262
"typo3/cms-lowlevel": "^12.4 || ^13.4 || 13.*.*@dev",

ext_emconf.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
'category' => 'templates',
1414
'constraints' => [
1515
'depends' => [
16-
'typo3' => '12.4.0-13.4.99',
16+
'typo3' => '12.4.5-13.4.99',
1717
'rte_ckeditor' => '12.4.0-13.4.99',
1818
'seo' => '12.4.0-13.4.99',
1919
],

0 commit comments

Comments
 (0)