Skip to content

Google Fonts not cached #1604

@thomaskieslich

Description

@thomaskieslich

Bug Report

Prerequisites

  • Can you reproduce the problem on TYPO3 v13.4 LTS
  • Can you reproduce the problem on TYPO3 v14.0 LTS
  • Did you perform a cursory search
    to see if your bug or enhancement is already reported?

Description

In Version 16.0 no Google Fonts Cache generated.
https://github.com/benjaminkott/bootstrap_package/blob/master/Classes/Service/GoogleFontService.php

  1. if Font name in $url is a Single Word (Lato) the $content Variable in L73 will become empty in L75.
  2. If Font Name in $url has Spaces (Source Sans Pro" the isValidHttpsUrl() Function will fail.

Steps to Reproduce

  1. change Fontname in Settings
  2. reload Page
  3. public/typo3temp/assets/bootstrappackage/fonts/*/ has only a empty webfont.css

Expected behavior

Fonts and webfont.css will be created

Versions

"bk2k/bootstrap-package": "^16.0.0",

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions