Skip to content

Commit be72815

Browse files
fix: routes clean up done
1 parent 89660df commit be72815

15 files changed

+75
-97
lines changed

packages/Webkul/Admin/src/Http/routes.php

Lines changed: 0 additions & 49 deletions
This file was deleted.

packages/Webkul/Admin/src/Providers/AdminServiceProvider.php

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,15 @@
22

33
namespace Webkul\Admin\Providers;
44

5+
use Illuminate\Contracts\Debug\ExceptionHandler;
56
use Illuminate\Database\Eloquent\Relations\Relation;
67
use Illuminate\Foundation\AliasLoader;
78
use Illuminate\Routing\Router;
89
use Illuminate\Support\Facades\Blade;
910
use Illuminate\Support\Facades\Route;
1011
use Illuminate\Support\ServiceProvider;
12+
use Webkul\Admin\Exceptions\Handler;
13+
use Webkul\Admin\Http\Middleware\Bouncer as BouncerMiddleware;
1114
use Webkul\Admin\Http\Middleware\Locale;
1215

1316
class AdminServiceProvider extends ServiceProvider
@@ -17,11 +20,13 @@ class AdminServiceProvider extends ServiceProvider
1720
*/
1821
public function boot(Router $router): void
1922
{
20-
include __DIR__.'/../Http/helpers.php';
23+
$router->aliasMiddleware('user', BouncerMiddleware::class);
24+
25+
$router->aliasMiddleware('admin_locale', Locale::class);
2126

22-
Route::middleware('web')->group(__DIR__.'/../Routes/web.php');
27+
include __DIR__.'/../Http/helpers.php';
2328

24-
$this->loadRoutesFrom(__DIR__.'/../Http/routes.php');
29+
Route::middleware(['web', 'admin_locale'])->group(__DIR__.'/../Routes/web.php');
2530

2631
$this->loadMigrationsFrom(__DIR__.'/../Database/Migrations');
2732

@@ -31,19 +36,15 @@ public function boot(Router $router): void
3136

3237
Blade::anonymousComponentPath(__DIR__.'/../Resources/views/components', 'admin');
3338

34-
$this->app->bind(\Illuminate\Contracts\Debug\ExceptionHandler::class, \Webkul\Admin\Exceptions\Handler::class);
35-
36-
$router->aliasMiddleware('user', \Webkul\Admin\Http\Middleware\Bouncer::class);
37-
38-
$router->aliasMiddleware('admin_locale', Locale::class);
39+
$this->app->bind(ExceptionHandler::class, Handler::class);
3940

4041
Relation::morphMap([
41-
'leads' => 'Webkul\Lead\Models\Lead',
42-
'products' => 'Webkul\Product\Models\Product',
43-
'persons' => 'Webkul\Contact\Models\Person',
44-
'organizations' => 'Webkul\Contact\Models\Organization',
45-
'quotes' => 'Webkul\Quote\Models\Quote',
46-
'warehouses' => 'Webkul\Warehouse\Models\Warehouse',
42+
'leads' => \Webkul\Lead\Models\Lead::class,
43+
'organizations' => \Webkul\Contact\Models\Organization::class,
44+
'persons' => \Webkul\Contact\Models\Person::class,
45+
'products' => \Webkul\Product\Models\Product::class,
46+
'quotes' => \Webkul\Quote\Models\Quote::class,
47+
'warehouses' => \Webkul\Warehouse\Models\Warehouse::class,
4748
]);
4849

4950
$this->app->register(EventServiceProvider::class);

packages/Webkul/Admin/src/Providers/ModuleServiceProvider.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,5 @@
66

77
class ModuleServiceProvider extends BaseModuleServiceProvider
88
{
9-
protected $models = [
10-
];
9+
protected $models = [];
1110
}

packages/Webkul/Admin/src/Routes/activities-routes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/**
77
* Settings routes.
88
*/
9-
Route::group(['middleware' => ['web', 'user', 'admin_locale'], 'prefix' => config('app.admin_path')], function () {
9+
Route::group(['middleware' => ['user'], 'prefix' => config('app.admin_path')], function () {
1010
/**
1111
* Persons routes.
1212
*/

packages/Webkul/Admin/src/Routes/auth-routes.php

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,33 @@
66
use Webkul\Admin\Http\Controllers\User\ResetPasswordController;
77
use Webkul\Admin\Http\Controllers\User\SessionController;
88

9+
/**
10+
* Home routes.
11+
*/
12+
Route::get('/', [Controller::class, 'redirectToLogin'])->name('krayin.home');
13+
914
/**
1015
* Auth routes.
1116
*/
12-
Route::group(['middleware' => ['web', 'admin_locale'], 'prefix' => config('app.admin_path')], function () {
17+
Route::group(['prefix' => config('app.admin_path')], function () {
1318
/**
1419
* Redirect route.
1520
*/
1621
Route::get('/', [Controller::class, 'redirectToLogin']);
1722

18-
Route::controller(SessionController::class)->prefix('login')->group(function () {
19-
/**
20-
* Login routes.
21-
*/
22-
Route::get('', 'create')->name('admin.session.create');
23+
/**
24+
* Session routes.
25+
*/
26+
Route::controller(SessionController::class)->group(function () {
27+
Route::prefix('login')->group(function () {
28+
Route::get('', 'create')->name('admin.session.create');
29+
30+
Route::post('', 'store')->name('admin.session.store');
31+
});
2332

24-
/**
25-
* Login post route to admin auth controller.
26-
*/
27-
Route::post('', 'store')->name('admin.session.store');
33+
Route::group(['middleware' => ['user']], function () {
34+
Route::delete('logout', 'destroy')->name('admin.session.destroy');
35+
});
2836
});
2937

3038
/**

packages/Webkul/Admin/src/Routes/configuration-routes.php

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,14 @@
66
/**
77
* Configuration routes.
88
*/
9-
Route::group(['middleware' => ['web', 'user', 'admin_locale'], 'prefix' => config('app.admin_path')], function () {
9+
Route::group(['middleware' => ['user'], 'prefix' => config('app.admin_path')], function () {
1010
Route::get('configuration/search', [ConfigurationController::class, 'search'])->name('admin.configuration.search');
1111

1212
Route::controller(ConfigurationController::class)->prefix('configuration/{slug?}/{slug2?}')->group(function () {
13-
1413
Route::get('', 'index')->name('admin.configuration.index');
1514

1615
Route::post('', 'store')->name('admin.configuration.store');
1716

18-
Route::get('{path}', 'download')->defaults('_config', [
19-
'redirect' => 'admin.configuration.index',
20-
])->name('admin.configuration.download');
17+
Route::get('{path}', 'download')->name('admin.configuration.download');
2118
});
2219
});

packages/Webkul/Admin/src/Routes/contacts-routes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
/**
1010
* Settings routes.
1111
*/
12-
Route::group(['middleware' => ['web', 'user', 'admin_locale'], 'prefix' => config('app.admin_path')], function () {
12+
Route::group(['middleware' => ['user'], 'prefix' => config('app.admin_path')], function () {
1313
Route::prefix('contacts')->group(function () {
1414
/**
1515
* Persons routes.

packages/Webkul/Admin/src/Routes/dashboard-routes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/**
77
* Extra routes.
88
*/
9-
Route::group(['middleware' => ['web', 'user', 'admin_locale'], 'prefix' => config('app.admin_path')], function () {
9+
Route::group(['middleware' => ['user'], 'prefix' => config('app.admin_path')], function () {
1010
/**
1111
* Dashboard routes.
1212
*/

packages/Webkul/Admin/src/Routes/leads-routes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/**
1111
* Settings routes.
1212
*/
13-
Route::group(['middleware' => ['web', 'user', 'admin_locale'], 'prefix' => config('app.admin_path')], function () {
13+
Route::group(['middleware' => ['user'], 'prefix' => config('app.admin_path')], function () {
1414
/**
1515
* Leads routes.
1616
*/

packages/Webkul/Admin/src/Routes/mail-routes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
/**
77
* Settings routes.
88
*/
9-
Route::group(['middleware' => ['web', 'user', 'admin_locale'], 'prefix' => config('app.admin_path')], function () {
9+
Route::group(['middleware' => ['user'], 'prefix' => config('app.admin_path')], function () {
1010
/**
1111
* Email routes.
1212
*/

0 commit comments

Comments
 (0)