patch(commands): Delete unwated built files

When running babel we copy over some JS & JSON files we don't need to transpile, but as a result the test files get copied over to built locations which we don't want.

So now after finishing with the transpiling and generation of type declarations, we delete test files (either in `__tests__` folder or with `.spec` extension).

Author: benmvp

.npmignore

@@ -58,6 +58,7 @@
     "jest-runner-tsc": "^1.3.2",
     "jest-watch-typeahead": "^0.3.0",
     "lodash": "^4.17.11",
+    "rimraf": "^2.6.3",
     "typescript": "^3.2.1",
     "yargs": "^13.1.0"
   },

package.json

@@ -1,12 +1,28 @@
 import {resolve} from 'path'
-import {getBabelArgs, getTypescriptArgs} from '../utils'
+import {
+  getBabelArgs,
+  getTypescriptArgs,
+  getCopiedFilesToDelete,
+} from '../utils'
 import {BUILD_ARGS} from '../../../cli/args'
 import {ModuleFormat} from '../../types'
 import BASE_TSCONFIG from '../../test/tsconfig.json'
 
 const CWD = process.cwd()
 
 describe('getBabelArgs', () => {
+  describe('source files', () => {
+    it('uses current working directory for source files location', () => {
+      const [firstSetOfArgs] = getBabelArgs({
+        formats: BUILD_ARGS.formats.default,
+        out: BUILD_ARGS.out.default,
+        watch: BUILD_ARGS.watch.default,
+      })
+
+      expect(firstSetOfArgs.cliOptions.filenames).toEqual([resolve(CWD, 'src')])
+    })
+  })
+
   describe('formats + out', () => {
     it('returns empty array when empty formats are specified', () => {
       const babelArgsToRun = getBabelArgs({
@@ -195,14 +211,34 @@ describe('getTypescriptArgs', () => {
       })
     })
 
-    it('uses current working director for source files location', () => {
-      const typescriptArgs = getTypescriptArgs({
-        formats: new Set(['type'] as ModuleFormat[]),
-        out: BUILD_ARGS.out.default,
-        watch: BUILD_ARGS.watch.default,
+    describe('source files', () => {
+      it('uses current working directory for source files location', () => {
+        const typescriptArgs = getTypescriptArgs({
+          formats: new Set(['type'] as ModuleFormat[]),
+          out: BUILD_ARGS.out.default,
+          watch: BUILD_ARGS.watch.default,
+        })
+
+        expect(typescriptArgs).toContain(resolve(CWD, 'src/*.ts'))
       })
+    })
+  })
+})
+
+describe('getCopiedFilesToDelete', () => {
+  it('prepends the passed in output path to the glob patterns (when relative)', () => {
+    const files = getCopiedFilesToDelete('./built')
+
+    files.forEach((globPattern) => {
+      expect(globPattern).toMatch(new RegExp(`^${resolve(CWD, 'built')}/`))
+    })
+  })
+
+  it('prepends the passed in output path to the glob patterns (when absolute)', () => {
+    const files = getCopiedFilesToDelete('/path/to/built')
 
-      expect(typescriptArgs).toContain(resolve(CWD, 'src/*.ts'))
+    files.forEach((globPattern) => {
+      expect(globPattern).toMatch(new RegExp('/path/to/built/'))
     })
   })
 })

src/commands/build/__tests__/utils.spec.ts

@@ -3,7 +3,11 @@ import {exec} from 'child_process'
 import runBabel from './run-babel'
 import {BUILD_ARGS} from '../../cli/args'
 import {Result, ModuleFormat} from '../types'
-import {getBabelArgs, getTypescriptArgs} from './utils'
+import {
+  getBabelArgs,
+  getTypescriptArgs,
+  getCopiedFilesToDelete,
+} from './utils'
 
 const execAsync = promisify(exec)
 
@@ -44,6 +48,9 @@ export default async ({
         throw Error('Unable able to generate type definitions')
       }
     }
+
+    // remove all of the copied files that we don't want in built directory
+    await execAsync(`npx rimraf ${getCopiedFilesToDelete(out).join(' ')}`)
   } catch (error) {
     return {
       code: error.code || 1,

src/commands/build/index.ts

@@ -57,6 +57,11 @@ interface BuildArgs {
 
 const VALID_BABEL_FORMATS = new Set(['cjs', 'esm'] as ModuleFormat[])
 
+const BUILT_FILES_TO_REMOVE = [
+  '**/__tests__/',
+  '**/*.spec.*',
+]
+
 /**
  * Gets an array of options/arguments to pass babel, one for each valid format
  * @param {BuildArgs} options
@@ -117,3 +122,12 @@ export const getTypescriptArgs = ({formats, out, watch}: BuildArgs): string[] |
 
   return args
 }
+
+/**
+ * Gets list of glob patterns of copied files that should be deleted after building
+ * @param {string} outputPath A path (relative or absolute) to the output directory for the type definitions
+ * @returns {string[]}
+ */
+export const getCopiedFilesToDelete = (outputPath: string): string[] => (
+  BUILT_FILES_TO_REMOVE.map((glob) => resolve(`${outputPath}/${glob}`))
+)