unescaped latin-1 permitted in URI, but no ctrls

* reject ascii controls
* reject ascii <>{}`^|\
* permit latin-1, including nbsp+shy
* permit " (quotation mark)

Author: pajod

gunicorn/http/message.py

@@ -29,6 +29,34 @@
 VERSION_RE = re.compile(r"HTTP/(\d)\.(\d)")
 RFC9110_5_5_INVALID_AND_DANGEROUS = re.compile(r"[\0\r\n]")
 
+RFC3986_2_URI_SPECIALS = (
+    # gen-delims
+    ":/?#[]@"
+    # sub-delims
+    "!$&'()*+,;="
+    # for unreserved
+    "-._~"
+    # for pct-encoded
+    "%"
+    # notably absent from this list (must be pct-encoded):
+    #   \N{SPACE}
+    #   <> and {}
+    #   ` a.k.a \N{GRAVE ACCENT}
+    #   ^ a.k.a \N{CIRCUMFLEX ACCENT}
+    #   | a.k.a \N{VERTICAL LINE}
+    #   backslash a.k.a \N{REVERSE SOLIDUS}
+)
+GUNICORN_NONSTANDARD_URI_CHARACTERS = (
+    "\N{QUOTATION MARK}"
+    # used in tests/requests/valid/027.http (utf8 decoded as latin-1)
+    #   "\N{LATIN CAPITAL LETTER A WITH TILDE}"
+    #   "\N{NO-BREAK SPACE}"
+    # includes the above - all latin-1 upper bits
+    #   also includes "\N{SOFT HYPHEN}"
+    + bytes(range(0xA0,0xff+1)).decode("latin-1")
+)
+GUNICORN_URI_SPECIALS = RFC3986_2_URI_SPECIALS + GUNICORN_NONSTANDARD_URI_CHARACTERS
+URI_CHARACTERS_RE = re.compile(r"[%s0-9a-zA-Z]+" % (re.escape(GUNICORN_URI_SPECIALS)))
 
 class Message:
     def __init__(self, cfg, unreader, peer_addr):
@@ -425,6 +453,7 @@ def parse_request_line(self, line_bytes):
         if self.cfg.casefold_http_method:
             self.method = self.method.upper()
 
+        # https://datatracker.ietf.org/doc/html/rfc9112#section-3.2
         # URI
         self.uri = bits[1]
 
@@ -438,6 +467,9 @@ def parse_request_line(self, line_bytes):
         # => manually reject one always invalid URI: empty
         if len(self.uri) == 0:
             raise InvalidRequestLine(bytes_to_str(line_bytes))
+        # => reject URI exceeding characters listed in RFC 3986
+        if not URI_CHARACTERS_RE.fullmatch(self.uri):
+            raise InvalidRequestLine(bytes_to_str(line_bytes))
 
         try:
             parts = split_request_uri(self.uri)

tests/requests/invalid/nonascii_05.http

@@ -0,0 +1,4 @@
+GET /one\0/two HTTP/1.1\r\n
+Content-Length: 3\r\n
+\r\n
+WOW

tests/requests/invalid/nonascii_05.py

@@ -0,0 +1,3 @@
+from gunicorn.http.errors import InvalidRequestLine
+
+request = InvalidRequestLine

tests/requests/valid/041.http

@@ -0,0 +1,5 @@
+GET scheme+ext://user+ext:password!@[::1]:8000/path?query#frag HTTP/1.1\r\n
+Host: localhost\r\n
+CONTENT-LENGTH: 3\r\n
+\r\n
+odd

tests/requests/valid/041.py

@@ -0,0 +1,10 @@
+request = {
+    "method": "GET",
+    "uri": uri("scheme+ext://user+ext:password!@[::1]:8000/path?query#frag"),
+    "version": (1, 1),
+    "headers": [
+        ("HOST", "localhost"),
+        ("CONTENT-LENGTH", "3"),
+    ],
+    "body": b'odd'
+}

tests/requests/valid/042.http

@@ -0,0 +1,3 @@
+OPTIONS * HTTP/1.1\r\n
+Content-Length: 0\r\n
+\r\n

tests/requests/valid/042.py

@@ -0,0 +1,9 @@
+request = {
+    "method": "OPTIONS",
+    "uri": uri("*"),
+    "version": (1, 1),
+    "headers": [
+        ("CONTENT-LENGTH", "0"),
+    ],
+    "body": b''
+}