Skip to content

Commit f186fa3

Browse files
committed
Make loggers function atomic
Fixes #2784: ``` Traceback (most recent call last): File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gunicorn/arbiter.py", line 589, in spawn_worker worker.init_process() File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/uvicorn/workers.py", line 66, in init_process super(UvicornWorker, self).init_process() File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gunicorn/workers/base.py", line 116, in init_process self.log.close_on_exec() File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gunicorn/glogging.py", line 381, in close_on_exec for log in loggers(): File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gunicorn/glogging.py", line 94, in loggers return [logging.getLogger(name) for name in existing] File "/home/runner/work/galaxy/galaxy/galaxy root/.venv/lib/python3.7/site-packages/gunicorn/glogging.py", line 94, in <listcomp> return [logging.getLogger(name) for name in existing] RuntimeError: dictionary changed size during iteration ```
1 parent 1aae54a commit f186fa3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

gunicorn/glogging.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@
9090
def loggers():
9191
""" get list of all loggers """
9292
root = logging.root
93-
existing = root.manager.loggerDict.keys()
93+
existing = list(root.manager.loggerDict.keys())
9494
return [logging.getLogger(name) for name in existing]
9595

9696

0 commit comments

Comments
 (0)