Fix tests

Author: benoitlahoz

packages/rest/e2e-basic-controller/api/posts/post.controller.ts

@@ -15,7 +15,7 @@ export class PostController implements AbstractAssemblage {
   @Get('/')
   public findAll(_req: Request, res: Response) {
     const posts = this.repository.findAll();
-    res.status(200).send(JSON.stringify(posts || []));
+    res.status(200).json(posts || []);
   }
 
   @Get('/sender/:id')
@@ -24,7 +24,7 @@ export class PostController implements AbstractAssemblage {
     if (!posts) {
       res.sendStatus(404);
     }
-    res.status(200).send(JSON.stringify(posts));
+    res.status(200).json(posts);
   }
 
   @Get('/receiver/:id')
@@ -33,20 +33,20 @@ export class PostController implements AbstractAssemblage {
     if (!posts) {
       res.sendStatus(404);
     }
-    res.status(200).send(JSON.stringify(posts));
+    res.status(200).json(posts);
   }
 
   @Post('/')
   public create(req: Request, res: Response) {
     const post = this.repository.create(req.body);
-    res.status(201).send(JSON.stringify(post));
+    res.status(201).json(post);
   }
 
   @Delete('/delete/:id')
   public delete(req: Request, res: Response) {
     const deleted = this.repository.delete(Number(req.params.id));
     if (deleted) {
-      res.status(200).send(JSON.stringify(deleted));
+      res.status(200).json(deleted);
     }
     res.sendStatus(404);
   }

packages/rest/e2e-basic-controller/api/user/user.controller.ts

@@ -15,7 +15,7 @@ export class UserController implements AbstractAssemblage {
   @Get('/')
   public findAll(_req: Request, res: Response) {
     const users = this.repository.findAll();
-    res.status(200).send(JSON.stringify(users || []));
+    res.status(200).json(Array.isArray(users) ? users : []);
   }
 
   @Head('/headers')
@@ -29,50 +29,52 @@ export class UserController implements AbstractAssemblage {
 
   @Get('/id/:id')
   public findById(req: Request, res: Response) {
-    const user = this.repository.findById(req.params.id);
+    const id = String(req.params.id).trim();
+    const user = this.repository.findById(id);
     if (!user) {
       res.sendStatus(404);
+      return;
     }
-    res.status(200).send(JSON.stringify(user));
+    res.status(200).json(user);
   }
 
   @Get('/gender/:gender')
   public findByGender(req: Request, res: Response) {
-    const user = this.repository.findByGender(req.params.gender);
+    const gender = String(req.params.gender).trim();
+    const user = this.repository.findByGender(gender);
     if (!user) {
       res.sendStatus(404);
+      return;
     }
-    res.status(200).send(
-      JSON.stringify({
-        ...user,
-      })
-    );
+    res.status(200).json(user);
   }
 
   @Post('/')
   public create(req: Request, res: Response) {
     const user = this.repository.create(req.body);
-    res.status(201).send(JSON.stringify(user));
+    res.status(201).json(user);
   }
 
   @Put('/replace/:id')
   public replace(req: Request, res: Response) {
-    const user = this.repository.modify(req.params.id, req.body);
+    const id = String(req.params.id).trim();
+    const user = this.repository.modify(id, req.body);
     if (!user) {
       res.sendStatus(404);
       return;
     }
-    res.status(200).send(JSON.stringify(user));
+    res.status(200).json(user);
   }
 
   @Patch('/modify/:id')
   public modify(req: Request, res: Response) {
-    const user = this.repository.modify(req.params.id, req.body);
+    const id = String(req.params.id).trim();
+    const user = this.repository.modify(id, req.body);
     if (!user) {
       res.sendStatus(404);
       return;
     }
-    res.status(200).send(JSON.stringify(user));
+    res.status(200).json(user);
   }
   /*
   @All('/')