Merge pull request #38 from benox3/tests

Increase test coverage

Author: benox3

lib/server/NoScriptImg.js

@@ -5,10 +5,6 @@ export default class NoScriptImg extends Component {
   render() {
     const { alt, style, image} = this.props;
 
-    if(!image) {
-      return null;
-    }
-
     return (
       <noscript dangerouslySetInnerHTML={{
         __html:

package.json

@@ -66,6 +66,7 @@
     "react-addons-shallow-compare": "15.3.2",
     "react-addons-test-utils": "15.3.2",
     "react-dom": "15.3.2",
+    "rimraf": "2.5.4",
     "sinon": "1.17.6",
     "watch": "0.19.2",
     "webpack": "1.13.2",

test/component.js

@@ -2,9 +2,19 @@ import React from 'react';
 import { expect } from 'chai';
 import { shallow, mount, render } from 'enzyme';
 import Pic from '../lib/';
-import { spy } from 'sinon';
+import sinon from 'sinon';
 
 describe('Pic', function() {
+  let sandbox;
+
+  beforeEach(function() {
+    sandbox = sinon.sandbox.create();
+  });
+
+  afterEach(function () {
+    sandbox.restore();
+  });
+
   it('should render the first image in images', function() {
     const props = {
       alt: 'heart',
@@ -104,10 +114,30 @@ describe('Pic', function() {
       ]
     };
 
-    spy(Pic.prototype, 'inViewHandler');
+    sandbox.spy(Pic.prototype, 'inViewHandler');
     mount(<Pic { ...props } />);
 
-    expect(Pic.prototype.inViewHandler).to.have.property('callCount', 1);
+    expect(Pic.prototype.inViewHandler.callCount).to.equal(1);
+  });
+
+  it('should call componentWillUnmount when unmounted', function() {
+    const props = {
+      images: [
+        {
+          width: 290,
+          url: 'http://placehold.it/290?text=♥'
+        },
+        {
+          width: 320,
+          url: 'http://placehold.it/320?text=♥'
+        }
+      ]
+    };
+
+    sandbox.spy(Pic.prototype, 'componentWillUnmount');
+    const wrapper = mount(<Pic { ...props } />);
+    wrapper.unmount();
+    expect(Pic.prototype.componentWillUnmount.callCount).to.equal(1);
   });
 
   it('should set optimal image if renderOutOfView is true', function() {
@@ -125,10 +155,10 @@ describe('Pic', function() {
       ]
     };
 
-    spy(Pic.prototype, 'setResponsiveImage');
+    sandbox.spy(Pic.prototype, 'setResponsiveImage');
     mount(<Pic { ...props } />);
 
-    expect(Pic.prototype.setResponsiveImage).to.have.property('callCount', 1);
+    expect(Pic.prototype.setResponsiveImage.callCount).to.equal(1);
   });
 
   it('should set blur to false by default', function() {
@@ -250,4 +280,56 @@ describe('Pic', function() {
       pic.find('div').first().attr('style')
     ).to.contain(`background-color:${props.baseStyle.backgroundColor};`);
   });
+
+  it('should not render if a url in images is not a string', function() {
+    const props = {
+      alt: 'heart',
+      images: [
+        {
+          width: 290,
+          url: 'http://placehold.it/290?text=♥'
+        },
+        {
+          width: 320,
+          url: {}
+        }
+      ]
+    };
+
+    const wrapper = shallow(<Pic {...props} />);
+    expect(wrapper.find('img')).to.have.length(0);
+
+  });
+
+  it('should not render if a width in images is not a number', function() {
+    const props = {
+      alt: 'heart',
+      images: [
+        {
+          width: 290,
+          url: 'http://placehold.it/290?text=♥'
+        },
+        {
+          width: 'test',
+          url: 'http://placehold.it/290?text=♥'
+        }
+      ]
+    };
+
+    const wrapper = shallow(<Pic {...props} />);
+    expect(wrapper.find('img')).to.have.length(0);
+
+  });
+
+  it('should not render if no images passed through', function() {
+    const props = {
+      alt: 'heart',
+      images: []
+    };
+
+    const wrapper = shallow(<Pic {...props} />);
+    expect(wrapper.find('img')).to.have.length(0);
+
+  });
+
 });