Deprecate and drop :on_unhandled_error option

[morgoth]

It is possible to set GoodJob.preserve_job_records = :on_unhandled_error so the jobs are persisted only when error occurs.

I find it buggy over time, as some of the jobs are preserved and some not.
On the development env it seems to work as intended, as all jobs without error are deleted, but on production-like systems, many jobs are not deleted.

Instead of figuring out why is that, I would recommend to deprecate that feature and later remove.

When it was introduced (yes that's me ;-) it was a solution for cleaning up.
But since now GJ deletes job periodically it doesn't really make sense any more.
Furthermore GJ has a rich "performance" tab and other statistics that are not fully used when using "on_unhandled_error" option.

[bensheldon]

I think there is still some value to this setting. Especially when generating a lot of jobs, it's useful to only keep the ones that ultimately bubble up as exceptions in order to inspect them.

One of my more unfortunate learnings is that everyone seems to handle exceptions, discards, and inspection/error-handling completely differently.

[morgoth]

I see.
I noticed that on production all "Rails based" jobs like Active Storage analyze, Turbo streams, etc where deleted, but some app defined jobs stayed despite having no error. Some app based jobs were deleted as well, but I didn't recognize the difference between them.

For us persisting all jobs for performance statistics makes more sense anyway.
Feel free to close it.