Fix code inscpector violations N6

Fix code inscpector violations N6

Signed-off-by: Bensuperpc <[email protected]>

Author: bensuperpc

git/git-commit.sh

@@ -23,7 +23,6 @@ set -euo pipefail
 if (( $# == 2 )); then
     git commit -s -m "$1" -m "$2"
 elif (( $# == 1 )); then
-echo $1
     git commit -s -m "$1" -m "$1"
 else
     echo "Usage: ${0##*/} <Title> <Message>"

install.sh

@@ -113,12 +113,12 @@ echo "Install bash-scripts done"
 
 echo "Remove *.sh ..."
 # Move it by remove file extension (if does not exit)
-find /usr/bin -lname '/usr/bin/ben_script/*.sh' | while read NAME ; do sudo mv -nv "${NAME}" "${NAME%.sh}" || echo "Fail: ${NAME}" ; done
+find /usr/bin -lname '/usr/bin/ben_script/*.sh' | while read -r NAME ; do sudo mv -nv "${NAME}" "${NAME%.sh}" || echo "Fail: ${NAME}" ; done
 echo "Remove *.sh done"
 
 echo "Remove *.py ..."
 # Move it by remove file extension (if does not exit)
-find /usr/bin -lname '/usr/bin/ben_script/*.py' | while read NAME ; do sudo mv -nv "${NAME}" "${NAME%.sh}" || echo "Fail: ${NAME}" ; done
+find /usr/bin -lname '/usr/bin/ben_script/*.py' | while read -r NAME ; do sudo mv -nv "${NAME}" "${NAME%.sh}" || echo "Fail: ${NAME}" ; done
 echo "Remove *.py done"
 
 echo "Install done"

linux/hash/hash.sh

@@ -23,6 +23,7 @@ set -euo pipefail
 if [ $# -eq 0 ]
 then
     echo "No arguments supplied"
+    echo "Usage: ${0##*/} <file>"
     exit 1
 fi
 

linux/hash/hash_check.sh

@@ -23,12 +23,13 @@ set -euo pipefail
 if [ $# -eq 0 ]
 then
     echo "No arguments supplied"
+    echo "Usage: ${0##*/} <file to check>"
     exit 1
 fi
 
 #TYPE=sha512
-#less -f checksums.${TYPE} | parallel --pipe -N100 -j $(nproc) ${TYPE}sum --quiet -c -
+#less -f checksums.${TYPE} | parallel --pipe -N100 -j "$(nproc)" ${TYPE}sum --quiet -c -
 
 TYPE=sha3-512
-less -f checksums."${TYPE}" | parallel --pipe -N100 -j $(nproc) rhash --"${TYPE}" -c -
+less -f checksums."${TYPE}" | parallel --pipe -N100 -j "$(nproc)" rhash --"${TYPE}" -c -
 echo "OK"

linux/hash/hash_gen.sh

@@ -23,12 +23,13 @@ set -euo pipefail
 if [ $# -eq 0 ]
 then
     echo "No arguments supplied"
+    echo "Usage: ${0##*/} <file>"
     exit 1
 fi
 
 #TYPE=sha512
-#find $1 -type f -name "*" ! -name "checksums.*" | parallel -j $(nproc) ${TYPE}sum > checksums.${TYPE}
+#find $1 -type f -name "*" ! -name "checksums.*" | parallel -j "$(nproc)" ${TYPE}sum > checksums.${TYPE}
 
 TYPE=sha3-512
-find "$1" -type f -name "*" ! -name "checksums.*" | parallel -j $(nproc) rhash --"${TYPE}" > checksums."${TYPE}"
+find "$1" -type f -name "*" ! -name "checksums.*" | parallel -j "$(nproc)" rhash --"${TYPE}" > checksums."${TYPE}"
 echo "OK"