refactor: misc

Author: benthevining

ben-bot/main.cpp

@@ -37,10 +37,8 @@ namespace {
 {
     std::string result;
 
-    for (const auto fragment : strings) {
-        result += fragment;
-        result += ' ';
-    }
+    for (const auto fragment : strings)
+        result.append(std::format("{} ", fragment));
 
     return result;
 }

libbenbot/src/engine/ColorPrinting.cpp

@@ -12,6 +12,7 @@
  * ======================================================================================
  */
 
+#include <algorithm>
 #include <beman/inplace_vector/inplace_vector.hpp>
 #include <iostream>
 #include <libbenbot/Resources.hpp>
@@ -50,8 +51,11 @@ void Engine::print_logo_and_version() const
     cout << termcolor::grey << logoLines.front() << '\n'
          << termcolor::blue;
 
-    for (const auto line : logoLines | std::views::drop(1) | std::views::take(NumLogoLines - 2uz))
-        cout << line << '\n';
+    std::ranges::for_each(
+        logoLines | std::views::drop(1) | std::views::take(NumLogoLines - 2uz),
+        [](const string_view line) {
+            cout << line << '\n';
+        });
 
     cout << termcolor::grey << logoLines.back() << "\n\n"
          << termcolor::reset << termcolor::bold << get_name() << ", "
@@ -97,11 +101,13 @@ void print_colored_board(
 
     const auto lines = get_at_most_n_lines<BoardLines>(boardStr);
 
-    for (const auto line : lines | std::views::take(BoardLines - 1uz)) {
-        cout << line.substr(0uz, line.length() - 1uz)
-             << termcolor::white << line.back() << '\n'
-             << termcolor::reset;
-    }
+    std::ranges::for_each(
+        lines | std::views::take(BoardLines - 1uz),
+        [](const string_view line) {
+            cout << line.substr(0uz, line.length() - 1uz)
+                 << termcolor::white << line.back() << '\n'
+                 << termcolor::reset;
+        });
 
     cout << termcolor::white << lines.back() << '\n'
          << termcolor::reset;

libbenbot/src/search/Callbacks.cpp

@@ -55,6 +55,7 @@ auto Callbacks::make_uci_printer(
 
 namespace {
     using std::string;
+    using std::string_view;
 
     enum class Alignment : std::uint_least8_t {
         Left,
@@ -66,7 +67,7 @@ namespace {
 
     template <Alignment Align>
     [[nodiscard]] auto get_column_text(
-        const std::string_view text) -> string
+        const string_view text) -> string
     {
         assert(text.size() < COLUMN_WIDTH);
 
@@ -89,11 +90,14 @@ namespace {
 
     template <Alignment Align>
     void print_column_text(
-        const std::string_view text)
+        const string_view text)
     {
         std::cout << get_column_text<Align>(text);
     }
 
+    inline constexpr string_view FRACTIONAL_DURATION_FMT { "{:.2%Q %q}" };
+    inline constexpr string_view INTEGER_DURATION_FMT { "{:%Q %q}" };
+
     template <util::ChronoDuration Duration>
     [[nodiscard]] auto get_duration_string(
         const milliseconds duration) -> std::optional<string>
@@ -104,7 +108,7 @@ namespace {
             using FractionalDuration = util::FractionalDuration<Duration>;
 
             return std::format(
-                "{:.2%Q %q}",
+                FRACTIONAL_DURATION_FMT,
                 duration_cast<FractionalDuration>(duration));
         }
 
@@ -118,7 +122,9 @@ namespace {
         return get_duration_string<std::chrono::hours>(duration)
             .or_else([duration] { return get_duration_string<std::chrono::minutes>(duration); })
             .or_else([duration] { return get_duration_string<std::chrono::seconds>(duration); })
-            .or_else([duration] { return std::make_optional(std::format("{:%Q %q}", duration)); })
+            .or_else([duration] {
+                return std::make_optional(std::format(INTEGER_DURATION_FMT, duration));
+            })
             .value();
     }
 
@@ -241,12 +247,8 @@ namespace {
 
         string result;
 
-        for (const auto move : pv) {
-            result.append(printMove(move));
-            result.append(1uz, ' ');
-        }
-
-        result.pop_back(); // trim last space
+        for (const auto move : pv)
+            result.append(std::format("{} ", printMove(move)));
 
         return result;
     }