fix: removed some cppcheck-suppress usages

Author: benthevining

libbenbot/src/engine/Engine.cpp

@@ -89,7 +89,7 @@ void Engine::set_pretty_printing(const bool shouldPrettyPrint)
             [this](const Move move) { return pretty_print_move(move); }));
     } else {
         searcher.context.set_callbacks(search::Callbacks::make_uci_printer(
-            [this] noexcept { // cppcheck-suppress syntaxError
+            [this]() noexcept {
                 return debugMode.load(memory_order_relaxed);
             }));
     }

libchess/include/libchess/moves/MoveGen.hpp

@@ -198,7 +198,7 @@ namespace detail {
     [[nodiscard, gnu::const]] constexpr auto get_pawn_double_pushes(
         const Position& position, const Bitboard allOccupied)
     {
-        static constexpr auto pawnStartingRank = Side == Color::White ? Rank::Two : Rank::Seven; // cppcheck-suppress knownConditionTrueFalse
+        static constexpr auto pawnStartingRank = Side == Color::White ? Rank::Two : Rank::Seven;
 
         const auto pushes = pseudo_legal::pawn_double_pushes<Side>(
             position.pieces_for<Side>().pawns,

libchess/include/libchess/moves/PseudoLegal.hpp

@@ -138,7 +138,7 @@ constexpr auto pawn_double_pushes(
     const auto moves = patterns::pawn_double_pushes<Side>(startingPawns) & occupiedSquares.inverse();
 
     // Need to filter out any pushes that would jump over a piece on the third/sixth rank
-    static constexpr auto rankMask = Side == Color::White ? ranks::THREE : ranks::SIX; // cppcheck-suppress knownConditionTrueFalse
+    static constexpr auto rankMask = Side == Color::White ? ranks::THREE : ranks::SIX;
 
     const auto fileMask = board::fills::file(occupiedSquares & rankMask);
 

libchess/src/notation/PGN.cpp

@@ -460,7 +460,7 @@ namespace {
         // write extra metadata tags not part of seven tag roster
         auto otherTags = metadata
                        | std::views::filter([](const auto& it) {
-                             return not std::ranges::contains(sevenTagRoster, it.first); // cppcheck-suppress internalAstError
+                             return not std::ranges::contains(sevenTagRoster, it.first);
                          });
 
         for (const auto& [key, value] : otherTags) {