fix: misc linter warnings

Author: benthevining

libbenbot/include/libbenbot/engine/Engine.hpp

@@ -204,7 +204,7 @@ class [[nodiscard]] Engine final : public uci::EngineBase {
         },
         CustomCommand {
             .name = "options",
-            .action = [this](const string_view args){ print_options(); },
+            .action = CustomCommand::void_cb([this]{ print_options(); }),
             .description = "Dump current UCI option values",
             .argsHelp = {}
         },

libbenbot/include/libbenbot/search/Context.hpp

@@ -54,6 +54,8 @@ struct Context final {
     Context(Context&&)            = delete;
     Context& operator=(Context&&) = delete;
 
+    ~Context() = default;
+
     /** Performs a search.
         Results will be propagated via the ``callbacks`` that have been
         assigned.

libbenbot/include/libbenbot/search/Options.hpp

@@ -69,7 +69,7 @@ struct Options final {
      */
     chess::moves::MoveList movesToSearch;
 
-    /** If true, the search should not exit until a ``xtop`` or ``exit``
+    /** If true, the search should not exit until a ``stop`` or ``exit``
         command is received.
      */
     bool infinite { false };

libbenbot/src/engine/Bench.cpp

@@ -88,6 +88,8 @@ namespace {
         BenchSearcherThread(BenchSearcherThread&&)            = delete;
         BenchSearcherThread& operator=(BenchSearcherThread&&) = delete;
 
+        ~BenchSearcherThread() = default;
+
         [[nodiscard]] auto finished() const noexcept -> bool { return not thread.context.in_progress(); }
 
         [[nodiscard]] auto get_result() const noexcept -> SearchResult

libbenbot/src/engine/ColorPrinting.cpp

@@ -43,12 +43,14 @@ namespace {
 
 void Engine::print_logo_and_version() const
 {
-    const auto logoLines = get_at_most_n_lines<11uz>(resources::get_ascii_logo());
+    static constexpr auto NumLogoLines = 11uz;
+
+    const auto logoLines = get_at_most_n_lines<NumLogoLines>(resources::get_ascii_logo());
 
     cout << termcolor::grey << logoLines.front() << '\n'
          << termcolor::blue;
 
-    for (const auto line : logoLines | std::views::drop(1) | std::views::take(logoLines.capacity() - 2uz))
+    for (const auto line : logoLines | std::views::drop(1) | std::views::take(NumLogoLines - 2uz))
         cout << line << '\n';
 
     cout << termcolor::grey << logoLines.back() << "\n\n"
@@ -91,9 +93,11 @@ void print_colored_board(
 {
     const auto boardStr = utf8 ? print_utf8(pos) : print_ascii(pos);
 
-    const auto lines = get_at_most_n_lines<9uz>(boardStr);
+    static constexpr auto BoardLines = 9uz;
+
+    const auto lines = get_at_most_n_lines<BoardLines>(boardStr);
 
-    for (const auto line : lines | std::views::take(lines.capacity() - 1uz)) {
+    for (const auto line : lines | std::views::take(BoardLines - 1uz)) {
         cout << line.substr(0uz, line.length() - 1uz)
              << termcolor::white << line.back() << '\n'
              << termcolor::reset;

libbenbot/src/search/Search.cpp

@@ -110,7 +110,7 @@ namespace {
         {
         }
 
-        AlphaBetaContext(const AlphaBetaContext&)            = delete;
+        AlphaBetaContext(const AlphaBetaContext&)            = default;
         AlphaBetaContext& operator=(const AlphaBetaContext&) = delete;
 
         template <bool PVNode>

libbenbot/src/search/TimeManagement.hpp

@@ -69,6 +69,8 @@ struct Interrupter final {
     Interrupter(Interrupter&&)            = delete;
     Interrupter& operator=(Interrupter&&) = delete;
 
+    ~Interrupter() = default;
+
     [[nodiscard]] auto get_search_duration() const noexcept -> milliseconds { return timer.get_duration(); }
 
     // returns time remaining until abort time, or nullopt if there's no time bound