Add disableGetMany, should fix #84

Author: benwinding

README.md

@@ -111,6 +111,8 @@ const config: ImportConfig = {
   disableCreateMany?: boolean,
   // Disable the attempt to use "updateMany", will instead just use "update" calls
   disableUpdateMany?: boolean,
+  // Disable the attempt to use "getMany", will instead just use "getSingle" calls
+  disableGetMany?: boolean,
   // Disable "import new" button
   disableImportNew?: boolean;
   // Disable "import overwrite" button
@@ -152,6 +154,7 @@ Your dataprovider will need to implement the `.createMany()` method in order to
 | ----------------- | ------------------ | --------------- |
 | Creating from CSV | .createMany()      | .create()       |
 | Updating from CSV | .updateManyArray() | .update()       |
+| Checking which exist | .getMany() | .getSingle()       |
 
 *Note: You can disable this feature setting `disableCreateMany: true` or `disableUpdateMany: true` in the configuration.*
 ### Interfaces

demo/src/posts.js

@@ -43,6 +43,7 @@ const ListActions = (props) => {
     },
     // disableImportNew: true,
     // disableImportOverwrite: true,
+    // disableGetMany: true,
   };
   return (
     <TopToolbar className={className}>

src/config.interface.ts

@@ -7,6 +7,8 @@ export interface ImportConfig {
   disableCreateMany?: boolean,
   // Disable the attempt to use "updateMany", will instead just use "update" calls
   disableUpdateMany?: boolean,
+  // Disable the attempt to use "getMany", will instead just use "getOne" calls
+  disableGetMany?: boolean,
   // Disable "import new" button
   disableImportNew?: boolean;
   // Disable "import overwrite" button

src/import-controller.ts

@@ -15,6 +15,7 @@ export async function GetIdsColliding(
   dataProvider: DataProvider,
   csvValues: any[],
   resourceName: string,
+  disableGetMany: boolean | undefined,
 ): Promise<Identifier[]> {
   const logger = makeLogger(logging);
   const hasIds = csvValues.some((v) => v.id);
@@ -23,13 +24,65 @@ export async function GetIdsColliding(
   }
   try {
     const csvIds: Identifier[] = csvValues.filter(v => !!v.id).map((v) => v.id);
+    const recordsIdsColliding = await (disableGetMany 
+      ? GetIdsCollidingGetSingle( logging, translate, dataProvider, csvIds, resourceName )
+      : GetIdsCollidingGetMany( logging, translate, dataProvider, csvIds, resourceName )
+    );
+    return recordsIdsColliding;
+  } catch (error) {
+    logger.error("GetIdsColliding", { csvValues }, error);
+    throw translate("csv.parsing.collidingIds");
+  }
+}
+
+export async function GetIdsCollidingGetSingle(
+  logging: boolean,
+  translate: Translate,
+  dataProvider: DataProvider,
+  csvIds: Identifier[],
+  resourceName: string,
+): Promise<Identifier[]> {
+  const logger = makeLogger(logging);
+  try {
+    const recordsColliding = await Promise.all(csvIds.map(id => IsIdColliding(
+      dataProvider,
+      id,
+      resourceName,
+    )));
+    const recordIdsColliding = recordsColliding.filter(Boolean) as Identifier[];
+    return recordIdsColliding;
+  } catch (error) {
+    logger.error("GetIdsCollidingGetSingle", { csvIds }, error);
+    throw translate("csv.parsing.collidingIds");
+  }
+}
+
+export async function IsIdColliding(
+  dataProvider: DataProvider,
+  id: Identifier,
+  resourceName: string,
+) {
+  return dataProvider.getOne(resourceName, {id})
+    .then(_ => undefined)
+    .catch(_ => id);
+}
+
+export async function GetIdsCollidingGetMany(
+  logging: boolean,
+  translate: Translate,
+  dataProvider: DataProvider,
+  csvIds: Identifier[],
+  resourceName: string,
+): Promise<Identifier[]> {
+  const logger = makeLogger(logging);
+  try {
     const recordsColliding = await dataProvider.getMany(resourceName, {
       ids: csvIds,
     });
     const recordIdsColliding = recordsColliding.data.map((r) => r.id);
     return recordIdsColliding;
   } catch (error) {
-    logger.error("GetIdsColliding", { csvValues }, error);
+    logger.error("GetIdsCollidingGetMany", { csvIds }, error);
     throw translate("csv.parsing.collidingIds");
   }
 }

src/main-csv-button.tsx

@@ -27,6 +27,7 @@ export const MainCsvImport = (props: any) => {
     transformRows,
     disableCreateMany,
     disableUpdateMany,
+    disableGetMany,
     disableImportNew,
     disableImportOverwrite,
   } = props as ImportConfig;
@@ -90,7 +91,8 @@ export const MainCsvImport = (props: any) => {
         translate,
         dataProvider,
         csvItems,
-        resourceName
+        resourceName,
+        disableGetMany,
       );
       mounted && setIdsConflicting(collidingIds);
       const hasCollidingIds = !!collidingIds.length;