fix serialization and test

Author: benwtrent

server/src/main/java/org/elasticsearch/search/vectors/RescoreVectorBuilder.java

@@ -25,7 +25,6 @@
 
 import static org.elasticsearch.TransportVersions.RESCORE_VECTOR_ALLOW_ZERO;
 import static org.elasticsearch.TransportVersions.RESCORE_VECTOR_ALLOW_ZERO_BACKPORT_8_19;
-import static org.elasticsearch.TransportVersions.V_9_0_0;
 
 public class RescoreVectorBuilder implements Writeable, ToXContentObject {
 
@@ -61,7 +60,7 @@ public void writeTo(StreamOutput out) throws IOException {
         // We don't want to serialize a `0` oversample to a node that doesn't know what to do with it.
         if (oversample == NO_OVERSAMPLE
             && out.getTransportVersion().before(RESCORE_VECTOR_ALLOW_ZERO)
-            && (out.getTransportVersion().between(RESCORE_VECTOR_ALLOW_ZERO_BACKPORT_8_19, V_9_0_0) == false)) {
+            && (out.getTransportVersion().isPatchFrom(RESCORE_VECTOR_ALLOW_ZERO_BACKPORT_8_19) == false)) {
             throw new ElasticsearchStatusException(
                 "[rescore_vector] does not support a 0 for ["
                     + OVERSAMPLE_FIELD.getPreferredName()

server/src/test/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapperTests.java

@@ -932,14 +932,17 @@ public void testRescoreVectorOldIndexVersion() {
     }
 
     public void testRescoreZeroVectorOldIndexVersion() {
-        IndexVersion incompatibleVersion = IndexVersionUtils.randomVersionBetween(
-            random(),
+        IndexVersion incompatibleVersion = randomFrom(
             IndexVersionUtils.randomVersionBetween(
                 random(),
                 IndexVersionUtils.getLowestReadCompatibleVersion(),
                 IndexVersionUtils.getPreviousVersion(IndexVersions.RESCORE_PARAMS_ALLOW_ZERO_TO_QUANTIZED_VECTORS_BACKPORT_8_X)
             ),
-            IndexVersionUtils.getPreviousVersion(IndexVersions.RESCORE_PARAMS_ALLOW_ZERO_TO_QUANTIZED_VECTORS)
+            IndexVersionUtils.randomVersionBetween(
+                random(),
+                IndexVersions.UPGRADE_TO_LUCENE_10_0_0,
+                IndexVersionUtils.getPreviousVersion(IndexVersions.RESCORE_PARAMS_ALLOW_ZERO_TO_QUANTIZED_VECTORS)
+            )
         );
         for (String indexType : List.of("int8_hnsw", "int8_flat", "int4_hnsw", "int4_flat", "bbq_hnsw", "bbq_flat")) {
             expectThrows(