fix: fix spikes_during_stim_detection and improve test_printouts

Author: jnsbck

ephyspy/features/utils.py

@@ -240,18 +240,21 @@ def where_stimulus(data: Union[EphysSweep, EphysSweepSet]) -> Union[bool, ndarra
 
 
 def where_spike_during_stimulus(
-    ft: SweepFeature, recompute: bool = False
+    ft: SweepFeature, recompute: bool = False, spike_ft: str = "peak"
 ) -> ndarray[bool]:
     """Checks where spikes occur during stimulus.
 
     Args:
         ft (SweepFeature): Spike feature to check.
         recompute (bool, optional): If True, recompute spikes. Defaults to False.
+        spike_ft (str, optional): Which spike feature to consider when inferring,
+            whether a spike is inside of the stimulus window, i.e. "peak",
+            "threshold", "trough", etc.. Defaults to "peak".
 
     Returns:
         ndarray: Boolean array with length of sweep.t; True where spikes occur
             during stimulus."""
-    t_thresh = ft.lookup_spike_feature("threshold_t", recompute=recompute)
+    t_thresh = ft.lookup_spike_feature(f"{spike_ft}_t", recompute=recompute)
     stim_onset = ft.lookup_sweep_feature("stim_onset", recompute=recompute)
     stim_end = ft.lookup_sweep_feature("stim_end", recompute=recompute)
     during_stim = where_between(t_thresh, stim_onset, stim_end)

tests/test_features.py

@@ -148,12 +148,12 @@ def test_no_new_features():
     ground_truth_features.keys(),
     ids=ground_truth_features.keys(),
 )
-def test_compare_against_ground_truth(ft_name):
+def test_against_ground_truth(ft_name):
     est = computed_features[ft_name]
     true = ground_truth_features[ft_name]
     assert (
         np.allclose(est, true) or np.isnan(est) and np.isnan(true)
-    ), f"Feature {ft_name} has changed vs. latest ground truth."
+    ), f"{ft_name} has changed vs. ground truth: {est:.2} vs. {true:.2}."
 
 
 test_sweepset.clear_features()