Skip to content

Commit f3dadd4

Browse files
committed
fix: change units of upstroke and downstroke
1 parent 320ba81 commit f3dadd4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

ephyspy/features/spike_features.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def __init__(self, data=None, **kwargs):
7070
super().__init__(data, **kwargs)
7171

7272
def _compute(self, recompute=False, store_diagnostics=True):
73-
upstroke = self.lookup_spike_feature("upstroke", recompute=recompute)
73+
upstroke = self.lookup_spike_feature("upstroke", recompute=recompute) * 1e3
7474
upstroke_v = self.lookup_spike_feature("upstroke_v", recompute=recompute)
7575
upstroke_t = self.lookup_spike_feature("upstroke_t", recompute=recompute)
7676
upstroke_idx = self.lookup_spike_feature("upstroke_index", recompute=recompute)
@@ -87,7 +87,7 @@ def _compute(self, recompute=False, store_diagnostics=True):
8787
def _plot(self, ax: Optional[Axes] = None, selected_idxs=None, **kwargs) -> Axes:
8888
idxs = slice(None) if selected_idxs is None else selected_idxs
8989
up_t, up_v = unpack(self.diagnostics, ["upstroke_t", "upstroke_v"])
90-
up_dvdt = self.value * 1e3
90+
up_dvdt = self.value
9191

9292
T = 15e-5
9393
t = np.linspace(up_t[idxs] - T, up_t[idxs] + T, 2)
@@ -111,7 +111,7 @@ def __init__(self, data=None, **kwargs):
111111
super().__init__(data, **kwargs)
112112

113113
def _compute(self, recompute=False, store_diagnostics=True):
114-
downstroke = self.lookup_spike_feature("downstroke", recompute=recompute)
114+
downstroke = self.lookup_spike_feature("downstroke", recompute=recompute) * 1e3
115115
downstroke_t = self.lookup_spike_feature("downstroke_t", recompute=recompute)
116116
downstroke_v = self.lookup_spike_feature("downstroke_v", recompute=recompute)
117117
downstroke_idx = self.lookup_spike_feature(
@@ -130,7 +130,7 @@ def _compute(self, recompute=False, store_diagnostics=True):
130130
def _plot(self, ax: Optional[Axes] = None, selected_idxs=None, **kwargs) -> Axes:
131131
idxs = slice(None) if selected_idxs is None else selected_idxs
132132
down_t, down_v = unpack(self.diagnostics, ["downstroke_t", "downstroke_v"])
133-
down_dvdt = self.value * 1e3
133+
down_dvdt = self.value
134134

135135
T = 25e-5
136136
t = np.linspace(down_t[idxs] - T, down_t[idxs] + T, 2)

0 commit comments

Comments
 (0)