Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

"halloactivated" event handler isn't unhooked on destroy() #258

@bcdickinson

Description

@bcdickinson

In hallo's _create method, there's a one-time event handler wired up to "halloactivated":

@element.one 'halloactivated', =>
   # We will populate the toolbar the first time this
   # editable is activated. This will make multiple
   # Hallo instances on same page load much faster
   @_prepareToolbar()

If you destroy the widget before it's been activated and then reinitialise it with a different set of plugins you get an error when the widget is first activated thrown from the handler whose set of plugins no longer matches`:

$(myElement).hallo({ plugins: { halloformat: {} });
$(myElement).hallo('destroy');
$(myElement).hallo({ plugins: { hallolists: {} });
$(myElement).click();
// Uncaught Error: Plugin halloformat not found

I'm just manually calling $(myElement).off('halloactivated') as a workaround for now.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions