Skip to content

BactoTraits GC bin synonym assignments are swapped (3 of 4 classes) #356

@turbomam

Description

@turbomam

Problem

Three of the four GC content bin classes have incorrect BactoTraits synonym assignments. The synonym strings are assigned to the wrong classes:

METPO ID Label Range BactoTraits Synonym Correct?
METPO:1000429 GC low <= 42.65 GC_42.65_57.0 WRONG (should be GC_<=42.65)
METPO:1000430 GC mid1 42.65-57 GC_>66.3 WRONG (should be GC_42.65_57.0)
METPO:1000431 GC mid2 57-66.3 GC_57.0_66.3 OK
METPO:1000432 GC high >= 66.3 GC_<=42.65 WRONG (should be GC_>66.3)

Fix

Swap the BactoTraits synonym values in src/templates/metpo_sheet.tsv:

  • METPO:1000429: GC_42.65_57.0 -> GC_<=42.65
  • METPO:1000430: GC_>66.3 -> GC_42.65_57.0
  • METPO:1000432: GC_<=42.65 -> GC_>66.3

Impact

Any downstream consumer using BactoTraits synonyms to resolve GC bin assignments would get wrong results for 3 of 4 bins.

Found during MetaTraits entity additions audit (branch metatraits-entity-additions, PR #355).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions