Improve typing

Author: bernaferrari

packages/backend/src/altNodes/iconDetection.ts

@@ -151,7 +151,7 @@ function checkChildrenRecursively(children: ReadonlyArray<SceneNode>): {
  * @param logDetails Set to true to print debug information to the console.
  * @returns True if the node is likely an icon, false otherwise.
  */
-export function isLikelyIcon(node: SceneNode, logDetails = true): boolean {
+export function isLikelyIcon(node: SceneNode, logDetails = false): boolean {
   const info: string[] = [`Node: ${node.name} (${node.type}, ID: ${node.id})`];
   let result = false;
   let reason = "";

packages/backend/src/altNodes/jsonNodeConversion.ts

@@ -4,6 +4,7 @@ import { variableToColorName } from "../tailwind/conversionTables";
 import { HasGeometryTrait, Node, Paint } from "../api_types";
 import { calculateRectangleFromBoundingBox } from "../common/commonPosition";
 import { isLikelyIcon } from "./iconDetection";
+import { AltNode } from "../alt_api_types";
 
 // Performance tracking counters
 export let getNodeByIdAsyncTime = 0;
@@ -265,10 +266,10 @@ function adjustChildrenOrder(node: any) {
  * @returns Potentially modified jsonNode, array of nodes (for inlined groups), or null
  */
 const processNodePair = async (
-  jsonNode: Node,
+  jsonNode: AltNode,
   figmaNode: SceneNode,
   settings: PluginSettings,
-  parentNode?: Node,
+  parentNode?: AltNode,
   parentCumulativeRotation: number = 0,
 ): Promise<Node | Node[] | null> => {
   if (!jsonNode.id) return null;
@@ -303,7 +304,7 @@ const processNodePair = async (
     );
   }
 
-  if ("rotation" in jsonNode) {
+  if ("rotation" in jsonNode && jsonNode.rotation) {
     jsonNode.rotation = -jsonNode.rotation * (180 / Math.PI);
   }
 
@@ -442,6 +443,7 @@ const processNodePair = async (
       jsonNode.styledTextSegments = styledTextSegments;
     }
 
+    // Inline text style.
     Object.assign(jsonNode, jsonNode.style);
     if (!jsonNode.textAutoResize) {
       jsonNode.textAutoResize = "NONE";
@@ -492,11 +494,16 @@ const processNodePair = async (
     (jsonNode as any).canBeFlattened = false;
   }
 
-  if ("individualStrokeWeights" in jsonNode) {
-    jsonNode.strokeTopWeight = jsonNode.individualStrokeWeights.top;
-    jsonNode.strokeBottomWeight = jsonNode.individualStrokeWeights.bottom;
-    jsonNode.strokeLeftWeight = jsonNode.individualStrokeWeights.left;
-    jsonNode.strokeRightWeight = jsonNode.individualStrokeWeights.right;
+  if (
+    "individualStrokeWeights" in jsonNode &&
+    jsonNode.individualStrokeWeights
+  ) {
+    (jsonNode as any).strokeTopWeight = jsonNode.individualStrokeWeights.top;
+    (jsonNode as any).strokeBottomWeight =
+      jsonNode.individualStrokeWeights.bottom;
+    (jsonNode as any).strokeLeftWeight = jsonNode.individualStrokeWeights.left;
+    (jsonNode as any).strokeRightWeight =
+      jsonNode.individualStrokeWeights.right;
   }
 
   await getColorVariables(jsonNode, settings);
@@ -554,7 +561,7 @@ const processNodePair = async (
     // Get only visible JSON children
     const visibleJsonChildren = jsonNode.children.filter(
       (child) => child.visible !== false,
-    );
+    ) as AltNode[];
 
     // Create a map of figma children by ID for easier matching
     const figmaChildrenById = new Map();

packages/backend/src/alt_api_types.ts

@@ -0,0 +1,15 @@
+import { type Node } from "./api_types";
+
+export type AltNode = Node & {
+  styledTextSegments: Array<
+    Pick<StyledTextSegment, any | "characters" | "start" | "end">
+  >;
+  cumulativeRotation: number;
+  uniqueName: string;
+  canBeFlattened: boolean;
+  isRelative: boolean;
+  width: number;
+  height: number;
+  x: number;
+  y: number;
+};

packages/backend/src/flutter/builderImpl/flutterBlend.ts

@@ -1,3 +1,4 @@
+import { AltNode } from "../../alt_api_types";
 import {
   generateWidgetCode,
   numberToFixedString,
@@ -38,7 +39,7 @@ export const flutterVisibility = (node: SceneNode, child: string): string => {
  * https://api.flutter.dev/flutter/widgets/Transform-class.html
  * that's how you convert angles to clockwise radians: angle * -pi/180
  */
-export const flutterRotation = (node: LayoutMixin, child: string): string => {
+export const flutterRotation = (node: AltNode, child: string): string => {
   if (
     node.rotation !== undefined &&
     child !== "" &&
@@ -58,7 +59,7 @@ export const flutterRotation = (node: LayoutMixin, child: string): string => {
 /**
  * Generates a rotation matrix string for Flutter transforms
  */
-export const generateRotationMatrix = (node: LayoutMixin): string => {
+export const generateRotationMatrix = (node: AltNode): string => {
   const rotation = (node.rotation || 0) + (node.cumulativeRotation || 0);
 
   if (Math.round(rotation) === 0) {

packages/backend/src/html/builderImpl/htmlBlend.ts

@@ -1,7 +1,6 @@
-import { roundToNearestHundreth } from "./../../common/numToAutoFixed";
-import { addWarning } from "../../common/commonConversionWarnings";
 import { numberToFixedString } from "../../common/numToAutoFixed";
 import { formatWithJSX } from "../../common/parseJSX";
+import { AltNode } from "../../alt_api_types";
 
 /**
  * https://tailwindcss.com/docs/opacity/
@@ -110,7 +109,7 @@ export const htmlVisibility = (
  * default is [-180, -90, -45, 0, 45, 90, 180], but '0' will be ignored:
  * if rotation was changed, let it be perceived. Therefore, 1 => 45
  */
-export const htmlRotation = (node: LayoutMixin, isJsx: boolean): string[] => {
+export const htmlRotation = (node: AltNode, isJsx: boolean): string[] => {
   const rotation =
     -Math.round((node.rotation || 0) + (node.cumulativeRotation || 0)) || 0;
 

packages/backend/src/swiftui/builderImpl/swiftuiBlend.ts

@@ -1,5 +1,6 @@
 import { SwiftUIModifier } from "types";
 import { numberToFixedString } from "../../common/numToAutoFixed";
+import { AltNode } from "../../alt_api_types";
 
 /**
  * https://developer.apple.com/documentation/swiftui/view/opacity(_:)
@@ -29,7 +30,7 @@ export const swiftuiVisibility = (
 /**
  * https://developer.apple.com/documentation/swiftui/modifiedcontent/rotationeffect(_:anchor:)
  */
-export const swiftuiRotation = (node: LayoutMixin): SwiftUIModifier | null => {
+export const swiftuiRotation = (node: AltNode): SwiftUIModifier | null => {
   const rotation = (node.rotation || 0) + (node.cumulativeRotation || 0);
   if (Math.round(rotation) !== 0) {
     return ["rotationEffect", `.degrees(${numberToFixedString(rotation)})`];