Use enum fmt formatting for RCodes

wandernauta · wandernauta · commit 8228f0603344 · 2024-03-28T21:11:13.000+01:00
diff --git a/dnsmon.cc b/dnsmon.cc
@@ -239,7 +239,7 @@ CheckResult DNSChecker::perform()
 
   if((RCode)dmr.dh.rcode != RCode::Noerror) {
     return fmt::format("Got DNS response with RCode {} from {} for question {}|{}",
-                       toString((RCode)dmr.dh.rcode), d_qname, d_nsip.toStringWithPort(), d_qtype);
+                       (RCode)dmr.dh.rcode, d_qname, d_nsip.toStringWithPort(), d_qtype);
   }
   
   std::unique_ptr<RRGen> rr;
@@ -329,7 +329,7 @@ CheckResult DNSSOAChecker::perform()
     
     if((RCode)dmr.dh.rcode != RCode::Noerror) {
       return fmt::format("Got DNS response with RCode {} for question {}|{}",
-                            toString((RCode)dmr.dh.rcode), d_domain, DNSType::SOA);
+                            (RCode)dmr.dh.rcode, d_domain, DNSType::SOA);
     }
   
     std::unique_ptr<RRGen> rr;
@@ -401,7 +401,7 @@ CheckResult RRSIGChecker::perform()
   
   if((RCode)dmr.dh.rcode != RCode::Noerror) {
     return fmt::format("Got DNS response with RCode {} from {} for question {}|{}",
-                       toString((RCode)dmr.dh.rcode), d_qname, d_nsip.toStringWithPort(), d_qtype);
+                       (RCode)dmr.dh.rcode, d_qname, d_nsip.toStringWithPort(), d_qtype);
   }
   
   std::unique_ptr<RRGen> rr;

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ CheckResult DNSChecker::perform()`
`239`	`239`
`240`	`240`	`if((RCode)dmr.dh.rcode != RCode::Noerror) {`
`241`	`241`	`return fmt::format("Got DNS response with RCode {} from {} for question {}\|{}",`
`242`		`- toString((RCode)dmr.dh.rcode), d_qname, d_nsip.toStringWithPort(), d_qtype);`
	`242`	`+ (RCode)dmr.dh.rcode, d_qname, d_nsip.toStringWithPort(), d_qtype);`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`std::unique_ptr<RRGen> rr;`
`@@ -329,7 +329,7 @@ CheckResult DNSSOAChecker::perform()`
`329`	`329`
`330`	`330`	`if((RCode)dmr.dh.rcode != RCode::Noerror) {`
`331`	`331`	`return fmt::format("Got DNS response with RCode {} for question {}\|{}",`
`332`		`- toString((RCode)dmr.dh.rcode), d_domain, DNSType::SOA);`
	`332`	`+ (RCode)dmr.dh.rcode, d_domain, DNSType::SOA);`
`333`	`333`	`}`
`334`	`334`
`335`	`335`	`std::unique_ptr<RRGen> rr;`
`@@ -401,7 +401,7 @@ CheckResult RRSIGChecker::perform()`
`401`	`401`
`402`	`402`	`if((RCode)dmr.dh.rcode != RCode::Noerror) {`
`403`	`403`	`return fmt::format("Got DNS response with RCode {} from {} for question {}\|{}",`
`404`		`- toString((RCode)dmr.dh.rcode), d_qname, d_nsip.toStringWithPort(), d_qtype);`
	`404`	`+ (RCode)dmr.dh.rcode, d_qname, d_nsip.toStringWithPort(), d_qtype);`
`405`	`405`	`}`
`406`	`406`
`407`	`407`	`std::unique_ptr<RRGen> rr;`