-
Notifications
You must be signed in to change notification settings - Fork 13
Open
Description
Problem
These methods are currently implemented as individual statements, but they could be implemented as the result of a function. This allows them to be documented better. Instead of functions, these would allow the user to access the values as if they were attributes, which is more pythonic.
Proposed solution
change
self.len_start = -1 * self.radius_muto
@property
def len_start(self):
return -1 * self.radius_muAssignees:
Labels:
rvesimulator/src/rvesimulator/microstructure/shpere_particles.py
Lines 96 to 103 in ea31752
| # initial coordinate for position of fibre | |
| self.len_start = -1 * self.radius_mu | |
| self.len_end = self.length + self.radius_mu | |
| self.wid_start = -1 * self.radius_mu | |
| self.wid_end = self.width + self.radius_mu | |
| self.hei_start = -1 * self.radius_mu | |
| self.hei_end = self.height + self.radius_mu | |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels