Make internal classes final

Author: jeromegamez

.php-cs-fixer.dist.php

@@ -17,6 +17,7 @@
         'concat_space' => [
             'spacing' => 'none',
         ],
+        'final_internal_class' => true,
         'fully_qualified_strict_types' => [
             'import_symbols' => true,
             'leading_backslash_in_global_namespace' => true,

src/Firebase/Auth/ApiClient.php

@@ -31,23 +31,23 @@
 /**
  * @internal
  */
-class ApiClient
+final readonly class ApiClient
 {
-    private readonly ProjectAwareAuthResourceUrlBuilder|TenantAwareAuthResourceUrlBuilder $awareAuthResourceUrlBuilder;
+    private ProjectAwareAuthResourceUrlBuilder|TenantAwareAuthResourceUrlBuilder $awareAuthResourceUrlBuilder;
 
-    private readonly AuthResourceUrlBuilder $authResourceUrlBuilder;
+    private AuthResourceUrlBuilder $authResourceUrlBuilder;
 
     /**
      * @param non-empty-string $projectId
      * @param non-empty-string|null $tenantId
      */
     public function __construct(
-        private readonly string $projectId,
-        private readonly ?string $tenantId,
-        private readonly ClientInterface $client,
-        private readonly GuzzleHandler $signInHandler,
-        private readonly ClockInterface $clock,
-        private readonly AuthApiExceptionConverter $errorHandler,
+        private string $projectId,
+        private ?string $tenantId,
+        private ClientInterface $client,
+        private GuzzleHandler $signInHandler,
+        private ClockInterface $clock,
+        private AuthApiExceptionConverter $errorHandler,
     ) {
         $this->awareAuthResourceUrlBuilder = $tenantId !== null
             ? TenantAwareAuthResourceUrlBuilder::forProjectAndTenant($projectId, $tenantId)

src/Firebase/Database/ApiClient.php

@@ -17,12 +17,12 @@
 /**
  * @internal
  */
-class ApiClient
+final readonly class ApiClient
 {
     public function __construct(
-        private readonly ClientInterface $client,
-        private readonly UrlBuilder $resourceUrlBuilder,
-        private readonly DatabaseApiExceptionConverter $errorHandler,
+        private ClientInterface $client,
+        private UrlBuilder $resourceUrlBuilder,
+        private DatabaseApiExceptionConverter $errorHandler,
     ) {
     }
 

src/Firebase/Database/Query/Filter/Shallow.php

@@ -11,7 +11,7 @@
 /**
  * @internal
  */
-final class Shallow implements Filter
+final readonly class Shallow implements Filter
 {
     use ModifierTrait;
 

src/Firebase/Database/Query/Sorter/OrderByKey.php

@@ -14,7 +14,7 @@
 /**
  * @internal
  */
-final class OrderByKey implements Sorter
+final readonly class OrderByKey implements Sorter
 {
     use ModifierTrait;
 

src/Firebase/Database/Query/Sorter/OrderByValue.php

@@ -14,7 +14,7 @@
 /**
  * @internal
  */
-final class OrderByValue implements Sorter
+final readonly class OrderByValue implements Sorter
 {
     use ModifierTrait;
 

src/Firebase/Exception/AuthApiExceptionConverter.php

@@ -30,9 +30,9 @@
 /**
  * @internal
  */
-class AuthApiExceptionConverter
+final readonly class AuthApiExceptionConverter
 {
-    public function __construct(private readonly ErrorResponseParser $responseParser)
+    public function __construct(private ErrorResponseParser $responseParser)
     {
     }
 

src/Firebase/Exception/DatabaseApiExceptionConverter.php

@@ -18,9 +18,9 @@
 /**
  * @internal
  */
-class DatabaseApiExceptionConverter
+final readonly class DatabaseApiExceptionConverter
 {
-    public function __construct(private readonly ErrorResponseParser $responseParser)
+    public function __construct(private ErrorResponseParser $responseParser)
     {
     }
 

src/Firebase/Exception/MessagingApiExceptionConverter.php

@@ -28,11 +28,11 @@
 /**
  * @internal
  */
-class MessagingApiExceptionConverter
+final readonly class MessagingApiExceptionConverter
 {
-    private readonly ErrorResponseParser $responseParser;
+    private ErrorResponseParser $responseParser;
 
-    private readonly ClockInterface $clock;
+    private ClockInterface $clock;
 
     public function __construct(?ClockInterface $clock = null)
     {

src/Firebase/Exception/RemoteConfigApiExceptionConverter.php

@@ -20,9 +20,9 @@
 /**
  * @internal
  */
-class RemoteConfigApiExceptionConverter
+final readonly class RemoteConfigApiExceptionConverter
 {
-    public function __construct(private readonly ErrorResponseParser $responseParser)
+    public function __construct(private ErrorResponseParser $responseParser)
     {
     }