Apply PHP 8.3 language migrations

Author: jeromegamez

.php-cs-fixer.dist.php

@@ -9,6 +9,7 @@
     ->setRiskyAllowed(true)
     ->setRules([
         '@PER-CS3x0:risky' => true,
+        '@PHPUnit9x1Migration:risky' => true,
         'class_attributes_separation' => true,
         'class_definition' => [
             'single_line' => true,

UPGRADE-8.0.md

@@ -17,6 +17,12 @@ from 7.x to 8.0.
 The following list has been generated with [roave/backward-compatibility-check](https://github.com/Roave/BackwardCompatibilityCheck).
 
 ```
+[BC] CHANGED: The parameter $uid of Kreait\Firebase\Request\EditUserTrait#withUid() changed from no type to Stringable|string
+[BC] CHANGED: The parameter $uid of Kreait\Firebase\Request\EditUserTrait#withUid() changed from no type to a non-contravariant Stringable|string
+[BC] CHANGED: The parameter $uid of Kreait\Firebase\Request\EditUserTrait#withUid() changed from no type to a non-contravariant Stringable|string
+[BC] CHANGED: The parameter $uid of Kreait\Firebase\Request\EditUserTrait#withUid() changed from no type to a non-contravariant Stringable|string
+[BC] CHANGED: The return type of Kreait\Firebase\RemoteConfig\ConditionalValue#value() changed from no type to string|array
+[BC] CHANGED: The return type of Kreait\Firebase\RemoteConfig\TagColor#__toString() changed from no type to string
 [BC] REMOVED: Class Kreait\Firebase\Contract\DynamicLinks has been deleted
 [BC] REMOVED: Class Kreait\Firebase\DynamicLink has been deleted
 [BC] REMOVED: Class Kreait\Firebase\DynamicLink\AnalyticsInfo has been deleted

src/Firebase/AppCheck.php

@@ -16,12 +16,12 @@
 /**
  * @internal
  */
-final class AppCheck implements Contract\AppCheck
+final readonly class AppCheck implements Contract\AppCheck
 {
     public function __construct(
-        private readonly ApiClient $client,
-        private readonly AppCheckTokenGenerator $tokenGenerator,
-        private readonly AppCheckTokenVerifier $tokenVerifier,
+        private ApiClient $client,
+        private AppCheckTokenGenerator $tokenGenerator,
+        private AppCheckTokenVerifier $tokenVerifier,
     ) {
     }
 

src/Firebase/AppCheck/ApiClient.php

@@ -17,11 +17,11 @@
  *
  * @phpstan-import-type AppCheckTokenShape from AppCheckToken
  */
-final class ApiClient
+final readonly class ApiClient
 {
     public function __construct(
-        private readonly ClientInterface $client,
-        private readonly AppCheckApiExceptionConverter $errorHandler,
+        private ClientInterface $client,
+        private AppCheckApiExceptionConverter $errorHandler,
     ) {
     }
 

src/Firebase/AppCheck/AppCheckToken.php

@@ -10,11 +10,11 @@
  *     ttl: string
  * }
  */
-final class AppCheckToken
+final readonly class AppCheckToken
 {
     private function __construct(
-        public readonly string $token,
-        public readonly string $ttl,
+        public string $token,
+        public string $ttl,
     ) {
     }
 

src/Firebase/AppCheck/AppCheckTokenGenerator.php

@@ -14,19 +14,19 @@
  *
  * @todo Add #[SensitiveParameter] attribute to the private key once the minimum required PHP version is >=8.2
  */
-final class AppCheckTokenGenerator
+final readonly class AppCheckTokenGenerator
 {
-    private const APP_CHECK_AUDIENCE = 'https://firebaseappcheck.googleapis.com/google.firebase.appcheck.v1.TokenExchangeService';
+    private const string APP_CHECK_AUDIENCE = 'https://firebaseappcheck.googleapis.com/google.firebase.appcheck.v1.TokenExchangeService';
 
-    private readonly ClockInterface $clock;
+    private ClockInterface $clock;
 
     /**
      * @param non-empty-string $clientEmail
      * @param non-empty-string $privateKey
      */
     public function __construct(
-        private readonly string $clientEmail,
-        private readonly string $privateKey,
+        private string $clientEmail,
+        private string $privateKey,
         ?ClockInterface $clock = null,
     ) {
         $this->clock = $clock ?? SystemClock::create();

src/Firebase/AppCheck/AppCheckTokenOptions.php

@@ -11,10 +11,10 @@
  *     ttl?: int|null,
  * }
  */
-final class AppCheckTokenOptions
+final readonly class AppCheckTokenOptions
 {
     private function __construct(
-        public readonly ?int $ttl = null,
+        public ?int $ttl = null,
     ) {
     }
 

src/Firebase/AppCheck/AppCheckTokenVerifier.php

@@ -19,16 +19,16 @@
  *
  * @phpstan-import-type DecodedAppCheckTokenShape from DecodedAppCheckToken
  */
-final class AppCheckTokenVerifier
+final readonly class AppCheckTokenVerifier
 {
-    private const APP_CHECK_ISSUER_PREFIX = 'https://firebaseappcheck.googleapis.com/';
+    private const string APP_CHECK_ISSUER_PREFIX = 'https://firebaseappcheck.googleapis.com/';
 
     /**
      * @param non-empty-string $projectId
      */
     public function __construct(
-        private readonly string $projectId,
-        private readonly CachedKeySet $keySet,
+        private string $projectId,
+        private CachedKeySet $keySet,
     ) {
     }
 

src/Firebase/AppCheck/DecodedAppCheckToken.php

@@ -14,20 +14,20 @@
  *     sub: non-empty-string,
  * }
  */
-final class DecodedAppCheckToken
+final readonly class DecodedAppCheckToken
 {
     /**
      * @param non-empty-string $app_id
      * @param array<string> $aud
      * @param non-empty-string $sub
      */
     private function __construct(
-        public readonly string $app_id,
-        public readonly array $aud,
-        public readonly int $exp,
-        public readonly int $iat,
-        public readonly string $iss,
-        public readonly string $sub,
+        public string $app_id,
+        public array $aud,
+        public int $exp,
+        public int $iat,
+        public string $iss,
+        public string $sub,
     ) {
     }
 

src/Firebase/AppCheck/VerifyAppCheckTokenResponse.php

@@ -12,14 +12,14 @@
  *     token: DecodedAppCheckTokenShape,
  * }
  */
-final class VerifyAppCheckTokenResponse
+final readonly class VerifyAppCheckTokenResponse
 {
     /**
      * @param non-empty-string $appId
      */
     public function __construct(
-        public readonly string $appId,
-        public readonly DecodedAppCheckToken $token,
+        public string $appId,
+        public DecodedAppCheckToken $token,
     ) {
     }
 }