Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

tag the service so it can be used in the route condition, #99 #100

Open
tacman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tag the service so it can be used in the route condition, #99 #100

tacman wants to merge 1 commit into from

Conversation

@tacman
Copy link

@tacman tacman commented Jun 9, 2022 

    /**
     * @Route("/blog/{page}", condition="service('flagception.manager.feature_manager').isActive('feature_123')")
     */
    public function listAction($page)
    {
        // ...
    }

For Symfony 6.1 users, this feels a bit cleaner than setting a value in the routing "defaults" _feature key.

@mKnoop mKnoop self-assigned this Aug 10, 2022
@mKnoop mKnoop added the review Issues that are currently checked label Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MmadiZaib MmadiZaib MmadiZaib approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@mKnoop mKnoop

Labels

review Issues that are currently checked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tacman @MmadiZaib @mKnoop