Only display status rights that are registered by the current lifecycle

Previously on queue/catalog rights pages, all ticket/asset status rights
were displayed, which was confusing and unnecessary.

Author: sunnavy

lib/RT/Lifecycle.pm

@@ -458,7 +458,7 @@ sub CheckRight {
     return $to eq 'deleted' ? 'DeleteTicket' : 'ModifyTicket';
 }
 
-=head3 RightsDescription [TYPE]
+=head3 RightsDescription [TYPE] [LIFECYCLE]
 
 Returns hash with description of rights that are defined for
 particular transitions.
@@ -468,11 +468,17 @@ particular transitions.
 sub RightsDescription {
     my $self = shift;
     my $type = shift;
+    my $lifecycle_name = shift;
 
     $self->FillCache unless keys %LIFECYCLES_CACHE;
 
+    if ( $lifecycle_name && !exists $LIFECYCLES_CACHE{$lifecycle_name} ) {
+        RT->Logger->warning("Lifecycle '$lifecycle_name' not found in LIFECYCLES_CACHE, ignoring");
+        undef $lifecycle_name;
+    }
+
     my %tmp;
-    foreach my $lifecycle ( values %LIFECYCLES_CACHE ) {
+    foreach my $lifecycle ( $lifecycle_name ? $LIFECYCLES_CACHE{$lifecycle_name} : values %LIFECYCLES_CACHE ) {
         next unless exists $lifecycle->{'rights'};
         next if $type and $lifecycle->{type} ne $type;
         while ( my ($transition, $right) = each %{ $lifecycle->{'rights'} } ) {

lib/RT/Record/Role/Rights.pm

@@ -108,8 +108,13 @@ sub AvailableRights {
     my $class = ref($self) || $self;
 
     my %rights;
-    $rights{$_->{Name}} = $_->{Description}
-        for values %{$RT::ACE::RIGHTS{$class} || {} };
+    if ( blessed $self && $self->DOES('RT::Record::Role::Lifecycle') ) {
+        %rights = RT::Lifecycle->RightsDescription( $self->LifecycleType, $self->Lifecycle );
+    }
+
+    $rights{ $_->{Name} } = $_->{Description}
+        for grep { $_->{Category} ne 'Status' } values %{ $RT::ACE::RIGHTS{$class} || {} };
+
     return \%rights;
 }