Avoid unnecessary database queries for non-existent report data

RT::Report::Entry inherits from RT::Record but lacks a backing database
table. Therefore, no need to query database for data that's not
pre-calculated.

For example, the _css_class attribute is only populated in some cases (when
rows are grouped by business hours or the involved custom date range sticks
to a static business hours spec). If this attribute is absent, calling
__Value('_css_class') would normally trigger an implicit database query. To
prevent this, here we unset PrimaryKeys to stop RT::Record from attempting
the invalid lookup.

This resolves SQL errors like:

    couldn't execute the query 'SELECT _css_class FROM  WHERE id = ?'

Author: sunnavy

lib/RT/Report.pm

@@ -1081,7 +1081,8 @@ sub DurationAsString {
         && $args{INFO}[-1]{business_time} )
     {
 
-        # 1 means business hours in SLA, its css is already generated and saved in _css_class.
+        # 1 means business hours in SLA, its css should be generated and saved in _css_class during grouping.
+        # If _css_class is unset, the aggregated data isn't tied to specific business hours, no wrapper is needed.
         if ( $args{INFO}[-1]{business_time} eq '1' ) {
             my $style = $self->__Value('_css_class');
             my $field;

lib/RT/Report/Entry.pm

@@ -228,6 +228,8 @@ sub DurationValue {
     return $seconds;
 }
 
+sub PrimaryKeys { ( id => undef ) }
+
 RT::Base->_ImportOverlays();
 
 1;

t/web/custom-date-ranges.t

@@ -109,6 +109,15 @@ $m->text_like( qr/36 hours\s*1/, 'GroupBy Just Monday 2nd row ticket count' );
 is( @default_rows, 1, '1 row with Default BH' );
 is( $default_rows[0]->text, '36 hours', 'GroupBy Default row label' );
 
+diag "Test custom date ranges Calculation with normal group by";
+$m->form_number(3);
+$m->select( 'GroupBy', 'Status' );
+$m->select( 'ChartFunction', 'SUM(Resolution Time)' );
+$m->set_fields( 'ChartFunction', [ 'COUNT', 2 ] );
+
+$m->submit_form_ok;
+ok( !$m->dom->at('span.business_hours_just_monday'), 'No cells with Just Monday BH' );
+ok( !$m->dom->at('span.business_hours_default'),     'No cells with Default BH' );
 
 diag "Test custom date ranges with specified business hours";
 $m->get_ok('/Prefs/CustomDateRanges.html');